Update prototype

yhay81 · yhay81 · commit a12ad8e7dc00 · 2021-01-24T19:14:20.000+09:00
diff --git a/patterns/creational/prototype.py b/patterns/creational/prototype.py
@@ -16,20 +16,20 @@
 
 Below provides an example of such Dispatcher, which contains three
 copies of the prototype: 'default', 'objecta' and 'objectb'.
-
-*TL;DR
-Creates new object instances by cloning prototype.
 """
 
+from typing import Any, Dict
 
-class Prototype:
 
-    value = "default"
+class Prototype:
+    def __init__(self, value: str = "default", **attrs: Any) -> None:
+        self.value = value
+        self.__dict__.update(attrs)
 
-    def clone(self, **attrs):
+    def clone(self, **attrs: Any) -> None:
         """Clone a prototype and update inner attributes dictionary"""
-        # Python in Practice, Mark Summerfield
-        obj = self.__class__()
+        # copy.deepcopy can be used instead of next line.
+        obj = self.__class__(**self.__dict__)
         obj.__dict__.update(attrs)
         return obj
 
@@ -38,33 +38,36 @@ class PrototypeDispatcher:
     def __init__(self):
         self._objects = {}
 
-    def get_objects(self):
+    def get_objects(self) -> Dict[str, Prototype]:
         """Get all objects"""
         return self._objects
 
-    def register_object(self, name, obj):
+    def register_object(self, name: str, obj: Prototype) -> None:
         """Register an object"""
         self._objects[name] = obj
 
-    def unregister_object(self, name):
+    def unregister_object(self, name: str) -> None:
         """Unregister an object"""
         del self._objects[name]
 
 
-def main():
+def main() -> None:
     """
     >>> dispatcher = PrototypeDispatcher()
     >>> prototype = Prototype()
 
     >>> d = prototype.clone()
     >>> a = prototype.clone(value='a-value', category='a')
-    >>> b = prototype.clone(value='b-value', is_checked=True)
+    >>> b = a.clone(value='b-value', is_checked=True)
     >>> dispatcher.register_object('objecta', a)
     >>> dispatcher.register_object('objectb', b)
     >>> dispatcher.register_object('default', d)
 
     >>> [{n: p.value} for n, p in dispatcher.get_objects().items()]
     [{'objecta': 'a-value'}, {'objectb': 'b-value'}, {'default': 'default'}]
+
+    >>> print(b.category, b.is_checked)
+    a True
     """
 
 
