update.sh: use mktemp

dominikh · dominikh · commit 57a5c6bb6d6b · 2016-02-21T09:08:26.000+01:00
Using mktemp solves two issues:

- it allows running multiple instances of update.sh in parallel. For
  example, someone might have two separate checkouts of the playground
  and intent to build them with different versions of Go. They might run
  both instances of update.sh in parallel to save time.

- it works correctly when someone has set their TMPDIR to something
  other than /tmp
diff --git a/playground/update.sh b/playground/update.sh
@@ -1,9 +1,12 @@
 #!/bin/sh
 set -e
 
+tmp_gopath=$(mktemp -d --suffix _play_gopath)
+tmp_goroot=$(mktemp -d --suffix _play_goroot)
+
 cleanup() {
-    rm -rf /tmp/gopherjsplayground_gopath
-    rm -rf /tmp/gopherjsplayground_goroot
+    rm -rf "$tmp_gopath"
+    rm -rf "$tmp_goroot"
     exit
 }
 
@@ -24,7 +27,7 @@ rm -r $PKG
 
 # Use an empty GOPATH workspace with just gopherjs,
 # so that all the standard library packages get written to GOROOT/pkg.
-export GOPATH=/tmp/gopherjsplayground_gopath
+export GOPATH="$tmp_gopath"
 mkdir -p $GOPATH/src/github.com/gopherjs/gopherjs
 cp -r $GOPHERJSGOPATH/src/github.com/gopherjs/gopherjs/* $GOPATH/src/github.com/gopherjs/gopherjs
 
@@ -35,8 +38,8 @@ cp $GOPATH/pkg/*_js_min/github.com/gopherjs/gopherjs/nosync.a $PKG/github.com/go
 
 # Make a copy of GOROOT that is user-writeable,
 # use it to build and copy out standard library packages.
-cp -r $(go env GOROOT) /tmp/gopherjsplayground_goroot
-export GOROOT=/tmp/gopherjsplayground_goroot
+cp -r $(go env GOROOT)/. "$tmp_goroot"
+export GOROOT="$tmp_goroot"
 gopherjs install -m \
          archive/tar \
          archive/zip \
