some comments

giograno · giograno · commit 13b29005bc84 · 2025-05-22T17:22:53.000+02:00
diff --git a/localstack-core/localstack/services/dynamodbstreams/provider.py b/localstack-core/localstack/services/dynamodbstreams/provider.py
@@ -51,7 +51,7 @@
 class DynamoDBStreamsProvider(DynamodbstreamsApi, ServiceLifecycleHook):
     shard_to_region: dict[str, str]
     """Map a shard iterator to the originating region. This is used in case of replica tables, as LocalStack keeps the
-    data in one region only, redirecting all the requests to replica regions."""
+    data in one region only, redirecting all the requests from replica regions."""
 
     def __init__(self):
         self.shard_to_region = {}
diff --git a/localstack-core/localstack/services/dynamodbstreams/v2/provider.py b/localstack-core/localstack/services/dynamodbstreams/v2/provider.py
@@ -26,7 +26,7 @@
 class DynamoDBStreamsProvider(DynamodbstreamsApi, ServiceLifecycleHook):
     shard_to_region: dict[str, str]
     """Map a shard iterator to the originating region. This is used in case of replica tables, as LocalStack keeps the
-    data in one region only, redirecting all the requests to replica regions."""
+    data in one region only, redirecting all the requests from replica regions."""
 
     def __init__(self):
         self.server = DynamodbServer.get()
diff --git a/tests/aws/services/dynamodb/test_dynamodb.py b/tests/aws/services/dynamodb/test_dynamodb.py
@@ -1138,8 +1138,11 @@ def test_global_tables_version_2019(
         assert "Replicas" not in response["Table"]
 
     @markers.aws.validated
-    # The stream label on the replica and replicated stream are the same (while they differ on AWS).
-    #   The region changes accordingly in the ARN. We test this with assertions.
+    # An ARM stream has a stream label as suffix. In AWS, such a label differs between the stream of the original table
+    # and the ones of the replicas. In LocalStack, it does not differ. The only difference in the stream ARNs is the
+    # region. Therefore, we skip the following paths from the snapshots.
+    # However, we run plain assertions to make sure that the region changes in the ARNs, i.e., the replica have their
+    # own stream.
     @markers.snapshot.skip_snapshot_verify(
         paths=["$..Streams..StreamArn", "$..Streams..StreamLabel"]
     )
@@ -1193,14 +1196,6 @@ def test_streams_on_global_tables(
         waiter = region_2_factory.dynamodb.get_waiter("table_exists")
         waiter.wait(TableName=table_name, WaiterConfig={"Delay": WAIT_SEC, "MaxAttempts": 20})
 
-        with pytest.raises(ClientError):
-            region_2_factory.dynamodb.update_table(
-                TableName=table_name,
-                StreamSpecification=StreamSpecification(
-                    StreamEnabled=True, StreamViewType=StreamViewType.NEW_AND_OLD_IMAGES
-                ),
-            )
-
         stream_arn_region = region_1_factory.dynamodb.describe_table(TableName=table_name)["Table"][
             "LatestStreamArn"
         ]
