Remove update exception and create() new EsmWorker instead of start()

gregfurman · gregfurman · commit 2f897d1c1154 · 2024-10-07T15:53:17.000+02:00
diff --git a/localstack-core/localstack/services/lambda_/event_source_mapping/esm_worker.py b/localstack-core/localstack/services/lambda_/event_source_mapping/esm_worker.py
@@ -103,12 +103,6 @@ def start(self):
         )
         self._poller_thread.start()
 
-    def update(self):
-        with self._state_lock:
-            self.current_state = EsmState.UPDATING
-            self.state_transition_reason = self.user_state_reason
-        self.start()
-
     def stop(self):
         with self._state_lock:
             self.enabled = False
diff --git a/localstack-core/localstack/services/lambda_/provider.py b/localstack-core/localstack/services/lambda_/provider.py
@@ -2155,9 +2155,6 @@ def update_event_source_mapping_v2(
                 "The resource you requested does not exist.", Type="User"
             )  # TODO: test?
 
-        if old_event_source_mapping["State"] == EsmState.UPDATING:
-            raise ResourceConflictException("Already updating", Type="User")
-
         # normalize values to overwrite
         event_source_mapping = old_event_source_mapping | request_data
 
@@ -2202,7 +2199,8 @@ def update_event_source_mapping_v2(
 
         # We should stop() the worker since the delete() will remove the ESM from the state mapping.
         esm_worker.stop()
-        updated_esm_worker.start()
+        # This will either create an EsmWorker in the CREATING state if enabled. Otherwise, the DISABLING state is set.
+        updated_esm_worker.create()
 
         return {**event_source_mapping, **temp_params}
 
