Events: migrate to new Counter type for Event Rule invocation analytics (#12388)

bentsku · web-flow · commit 7f97b189bdeb · 2025-03-19T21:51:21.000+01:00
diff --git a/localstack-core/localstack/services/events/analytics.py b/localstack-core/localstack/services/events/analytics.py
@@ -0,0 +1,14 @@
+from enum import StrEnum
+
+from localstack.utils.analytics.metrics import Counter
+
+
+class InvocationStatus(StrEnum):
+    success = "success"
+    error = "error"
+
+
+# number of EventBridge rule invocations per target (e.g., aws:lambda)
+# - status label can be `success` or `error`, see InvocationStatus
+# - service label is the target service name
+rule_invocation = Counter(namespace="events", name="rule_invocations", labels=["status", "service"])
diff --git a/localstack-core/localstack/services/events/provider.py b/localstack-core/localstack/services/events/provider.py
@@ -154,7 +154,6 @@
     TargetSenderDict,
     TargetSenderFactory,
 )
-from localstack.services.events.usage import rule_error, rule_invocation
 from localstack.services.events.utils import (
     TARGET_ID_PATTERN,
     extract_connection_name,
@@ -172,6 +171,8 @@
 from localstack.utils.strings import long_uid
 from localstack.utils.time import TIMESTAMP_FORMAT_TZ, timestamp
 
+from .analytics import InvocationStatus, rule_invocation
+
 LOG = logging.getLogger(__name__)
 
 ARCHIVE_TARGET_ID_NAME_PATTERN = re.compile(r"^Events-Archive-(?P<name>[a-zA-Z0-9_-]+)$")
@@ -1889,9 +1890,16 @@ def _process_rules(
                     target_sender = self._target_sender_store[target_unique_id]
                     try:
                         target_sender.process_event(event_formatted.copy())
-                        rule_invocation.record(target_sender.service)
+                        rule_invocation.labels(
+                            status=InvocationStatus.success,
+                            service=target_sender.service,
+                        ).increment()
+
                     except Exception as error:
-                        rule_error.record(target_sender.service)
+                        rule_invocation.labels(
+                            status=InvocationStatus.error,
+                            service=target_sender.service,
+                        ).increment()
                         # Log the error but don't modify the response
                         LOG.info(
                             json.dumps(
diff --git a/localstack-core/localstack/services/events/usage.py b/localstack-core/localstack/services/events/usage.py
