Remove additional unneeded skips

simonrw · simonrw · commit 86d58f30d1fe · 2025-08-15T12:13:53.000+01:00
diff --git a/tests/aws/services/cloudformation/engine/test_mappings.py b/tests/aws/services/cloudformation/engine/test_mappings.py
@@ -2,10 +2,9 @@
 
 import pytest
 from botocore.exceptions import ClientError
-from tests.aws.services.cloudformation.conftest import skip_if_v1_provider, skip_if_v2_provider
+from tests.aws.services.cloudformation.conftest import skip_if_v1_provider
 
 from localstack.testing.pytest import markers
-from localstack.testing.pytest.fixtures import StackDeployError
 from localstack.utils.files import load_file
 from localstack.utils.strings import short_uid
 
@@ -70,29 +69,6 @@ def test_mapping_with_nonexisting_key(self, aws_client, cleanups, snapshot):
             )
         snapshot.match("mapping_nonexisting_key_exc", e.value.response)
 
-    @skip_if_v2_provider("Validation", reason="replaced with v2 test below")
-    @markers.aws.only_localstack
-    def test_async_mapping_error_first_level(self, deploy_cfn_template):
-        """
-        We don't (yet) support validating mappings synchronously in `create_changeset` like AWS does, however
-        we don't fail with a good error message at all. This test ensures that the deployment fails with a
-        nicer error message than a Python traceback about "`None` has no attribute `get`".
-        """
-        topic_name = f"test-topic-{short_uid()}"
-        with pytest.raises(StackDeployError) as exc_info:
-            deploy_cfn_template(
-                template_path=os.path.join(
-                    THIS_DIR,
-                    "../../../templates/mappings/simple-mapping.yaml",
-                ),
-                parameters={
-                    "TopicName": topic_name,
-                    "TopicNameSuffixSelector": "C",
-                },
-            )
-
-        assert "Cannot find map key 'C' in mapping 'TopicSuffixMap'" in str(exc_info.value)
-
     @markers.aws.validated
     @skip_if_v1_provider("V1 provider is not in parity with AWS")
     def test_async_mapping_error_first_level_v2(self, aws_client, snapshot):
@@ -120,31 +96,6 @@ def test_async_mapping_error_first_level_v2(self, aws_client, snapshot):
 
         snapshot.match("error", exc_info.value)
 
-    @skip_if_v2_provider("Validation", reason="replaced with v2 test below")
-    @markers.aws.only_localstack
-    def test_async_mapping_error_second_level(self, deploy_cfn_template):
-        """
-        Similar to the `test_async_mapping_error_first_level` test above, but
-        checking the second level of mapping lookup
-        """
-        topic_name = f"test-topic-{short_uid()}"
-        with pytest.raises(StackDeployError) as exc_info:
-            deploy_cfn_template(
-                template_path=os.path.join(
-                    THIS_DIR,
-                    "../../../templates/mappings/simple-mapping.yaml",
-                ),
-                parameters={
-                    "TopicName": topic_name,
-                    "TopicNameSuffixSelector": "A",
-                    "TopicAttributeSelector": "NotValid",
-                },
-            )
-
-        assert "Cannot find map key 'NotValid' in mapping 'TopicSuffixMap' under key 'A'" in str(
-            exc_info.value
-        )
-
     @markers.aws.validated
     @skip_if_v1_provider("V1 provider is not in parity with AWS")
     def test_async_mapping_error_second_level_v2(self, aws_client, snapshot):
