Skip to content

Commit b9efaef

Browse files
committed
Add TODO
1 parent 009bff4 commit b9efaef

File tree

1 file changed

+1
-0
lines changed
  • localstack-core/localstack/services/lambda_/event_source_mapping/pollers

1 file changed

+1
-0
lines changed

localstack-core/localstack/services/lambda_/event_source_mapping/pollers/stream_poller.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,7 @@ def poll_events_from_shard(self, shard_id: str, shard_iterator: str):
202202
for batch in batched(collected_records, self.stream_parameters.get("BatchSize")):
203203
# This could potentially lead to data loss if forward_events_to_target raises an exception after a flush
204204
# which would otherwise be solved with checkpointing.
205+
# TODO: Implement checkpointing, leasing, etc. from https://docs.aws.amazon.com/streams/latest/dev/kcl-concepts.html
205206
self.forward_events_to_target(shard_id, next_shard_iterator, batch)
206207

207208
def forward_events_to_target(self, shard_id, next_shard_iterator, records):

0 commit comments

Comments
 (0)