make multipart composite by default

bentsku · bentsku · commit bc8b2b13bea5 · 2025-01-25T00:48:19.000+01:00
diff --git a/localstack-core/localstack/services/s3/models.py b/localstack-core/localstack/services/s3/models.py
@@ -435,7 +435,7 @@ def __init__(
         expires: Optional[datetime] = None,
         expiration: Optional[datetime] = None,  # come from lifecycle
         checksum_algorithm: Optional[ChecksumAlgorithm] = None,
-        checksum_type: Optional[ChecksumType] = ChecksumType.FULL_OBJECT,
+        checksum_type: Optional[ChecksumType] = ChecksumType.COMPOSITE,
         encryption: Optional[ServerSideEncryption] = None,  # inherit bucket
         kms_key_id: Optional[SSEKMSKeyId] = None,  # inherit bucket
         bucket_key_enabled: bool = False,  # inherit bucket
@@ -548,8 +548,7 @@ def complete_multipart(self, parts: CompletedPartList):
 
         multipart_etag = f"{object_etag.hexdigest()}-{len(parts)}"
         self.object.etag = multipart_etag
-        # TODO: manage checksum here!!! can be COMPOSITE or FULL_OBJECT
-        # previous is COMPOSITE
+        # TODO: implement FULL_OBJECT checksum type
         if has_checksum:
             checksum_value = f"{base64.b64encode(checksum_hash.digest()).decode()}-{len(parts)}"
             self.checksum_value = checksum_value
