Docker: Improve error messages around port-bound check

bblommers · bblommers · commit d20190d9ab5d · 2025-04-04T09:00:24.000Z
diff --git a/localstack-core/localstack/utils/docker_utils.py b/localstack-core/localstack/utils/docker_utils.py
@@ -154,16 +154,16 @@ def container_ports_can_be_bound(
             remove=True,
         )
     except Exception as e:
-        if "port is already allocated" not in str(e) and "address already in use" not in str(e):
+        if "address already in use" not in str(e):
             LOG.warning(
-                "Unexpected error when attempting to determine container port status: %s", e
+                "Unexpected error when attempting to determine container port status", exc_info=e
             )
         return False
     # TODO(srw): sometimes the command output from the docker container is "None", particularly when this function is
     #  invoked multiple times consecutively. Work out why.
     if to_str(result[0] or "").strip() != "test123":
         LOG.warning(
-            "Unexpected output when attempting to determine container port status: %s", result[0]
+            "Unexpected output when attempting to determine container port status: %s", result
         )
     return True
 

Original file line number	Diff line number	Diff line change
`@@ -154,16 +154,16 @@ def container_ports_can_be_bound(`
`154`	`154`	`remove=True,`
`155`	`155`	`)`
`156`	`156`	`except Exception as e:`
`157`		`- if "port is already allocated" not in str(e) and "address already in use" not in str(e):`
	`157`	`+ if "address already in use" not in str(e):`
`158`	`158`	`LOG.warning(`
`159`		`- "Unexpected error when attempting to determine container port status: %s", e`
	`159`	`+ "Unexpected error when attempting to determine container port status", exc_info=e`
`160`	`160`	`)`
`161`	`161`	`return False`
`162`	`162`	`# TODO(srw): sometimes the command output from the docker container is "None", particularly when this function is`
`163`	`163`	`# invoked multiple times consecutively. Work out why.`
`164`	`164`	`if to_str(result[0] or "").strip() != "test123":`
`165`	`165`	`LOG.warning(`
`166`		`- "Unexpected output when attempting to determine container port status: %s", result[0]`
	`166`	`+ "Unexpected output when attempting to determine container port status: %s", result`
`167`	`167`	`)`
`168`	`168`	`return True`
`169`	`169`