remove legacy runtime in localstack/service/infra.py #11202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 3m 21s ⏱️ Results for commit b0d3431. |
alexrashed
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a PR to remove the code that was deprecated by #10942.
I left
signal_supervisor_restart()in the legacy module (it's still referenced in ext), but added a TODO.Considering this a minor change since we never documented
LEGACY_RUNTIMEand have, to my knowledge, not needed it so far.Changes
infra.pyhas been completely removed in favor of the new runtime frameworkTesting
One thing needs manual testing, namely the kill function of the health endpoint
python -m localstack.dev.run -e DEBUG=1curl -X POST -H 'Content-Type: application/json' localhost.localstack.cloud:4566/_localstack/health -d '{"action": "kill"}'still works