Skip to content

Remove duplicate --strip-extras flag in dependency pinning target #11666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

vignesh1507
Copy link
Contributor

Duplicate Flags: In the upgrade-pinned-dependencies target, --strip-extras is specified twice in the pip-compile commands:

$(VENV_RUN); pip-compile --strip-extras --upgrade --strip-extras -o requirements-basic.txt pyproject.toml

@silv-io silv-io added the semver: patch Non-breaking changes which can be included in patch releases label Oct 10, 2024
@silv-io silv-io self-requested a review October 10, 2024 13:36
Copy link
Member

@silv-io silv-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

@silv-io silv-io changed the title Updated the Makefile Remove duplicate --strip-extras flag in dependency pinning target Oct 10, 2024
@silv-io silv-io merged commit 2ececf0 into localstack:master Oct 10, 2024
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants