Skip to content

fix java home for macos #11888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2024
Merged

fix java home for macos #11888

merged 1 commit into from
Nov 21, 2024

Conversation

macnev2013
Copy link
Contributor

Motivation

This PR resolves the issue with Java home retrieval on macOS. For the temurin Java distribution, the Java home directory on macOS resides in /Contents/Home. This discrepancy caused errors in big data services when running in host mode.

Changes

Updated the logic for Java home retrieval on macOS to accommodate the temurin distribution structure.

@macnev2013 macnev2013 requested review from viren-nadkarni and removed request for alexrashed November 21, 2024 06:50
@macnev2013 macnev2013 added the semver: patch Non-breaking changes which can be included in patch releases label Nov 21, 2024
Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 43m 12s ⏱️ +46s
3 563 tests ±0  3 227 ✅ ±0  336 💤 ±0  0 ❌ ±0 
3 565 runs  ±0  3 227 ✅ ±0  338 💤 ±0  0 ❌ ±0 

Results for commit 799110b. ± Comparison against base commit 77b14d7.

@macnev2013 macnev2013 changed the title updated java home retrival fix java home for macos Nov 21, 2024
Copy link
Member

@viren-nadkarni viren-nadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for improving the devx in Mac OS ✔️

@macnev2013 macnev2013 merged commit 3be7ae0 into master Nov 21, 2024
38 of 39 checks passed
@macnev2013 macnev2013 deleted the fix/java-home branch November 21, 2024 09:16
@maxhoheiser
Copy link
Member

For me, it worked before the patch - and with the patch, it introduces a double nesting like so: Contents/Home/Contents/Home

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants