Skip to content

Add deprecation for Java-based event ruler #11964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

joe4dev
Copy link
Member

@joe4dev joe4dev commented Nov 29, 2024

Depends on #11960

Motivation

The Java-based event ruler is deprecated because our latest Python-native implementation introduced in 4.0.3 is faster, achieves great AWS parity, and fixes compatibility issues with the StepFunctions JSONata feature.

Changes

  • Deprecate EVENT_RULE_ENGINE config used for opt-into the Java-based event ruler
  • Remove unused POLL_INTERVAL_SEC

Notes

We now have a comprehensive test suite and can be confident that (almost) all cases are covered.

@joe4dev joe4dev added the semver: patch Non-breaking changes which can be included in patch releases label Nov 29, 2024
@joe4dev joe4dev added this to the 4.0.3 milestone Nov 29, 2024
@joe4dev joe4dev self-assigned this Nov 29, 2024
@joe4dev joe4dev requested review from bentsku and dominikschubert and removed request for dominikschubert, thrau, dfangl and gregfurman November 29, 2024 15:35
Copy link

S3 Image Test Results (AMD64 / ARM64)

  2 files    2 suites   4m 2s ⏱️
441 tests 389 ✅  52 💤 0 ❌
882 runs  778 ✅ 104 💤 0 ❌

Results for commit 24b6a85.

@joe4dev joe4dev merged commit 21210ce into master Nov 29, 2024
40 of 42 checks passed
@joe4dev joe4dev deleted the deprecate-java-event-ruler branch November 29, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants