Skip to content

Add test for EBS volume creation without size #12227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2025
Merged

Add test for EBS volume creation without size #12227

merged 1 commit into from
Feb 24, 2025

Conversation

nik-localstack
Copy link
Contributor

@nik-localstack nik-localstack commented Feb 4, 2025 •
edited
Loading

Motivation

Adding test for the relevant moto change getmoto/moto#8556

Changes

@nik-localstack nik-localstack self-assigned this Feb 4, 2025
localstack-bot
localstack-bot reviewed Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@localstack-bot localstack-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.

@nik-localstack nik-localstack added the semver: patch Non-breaking changes which can be included in patch releases label Feb 4, 2025
@localstack-bot
Copy link
Collaborator

localstack-bot commented Feb 4, 2025 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@nik-localstack
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

localstack-bot added a commit that referenced this pull request Feb 4, 2025
@localstack-bot
@nik-localstack has signed the CLA in #12227
fa905ef
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025 •
edited
Loading

LocalStack Community integration with Pro

 2 files  ±    0   2 suites  ±0   35s ⏱️ - 1h 51m 45s
23 tests  - 4 078  21 ✅  - 3 747  2 💤  - 331  0 ❌ ±0 
25 runs   - 4 078  21 ✅  - 3 747  4 💤  - 331  0 ❌ ±0 

Results for commit c80b547. ± Comparison against base commit 230914f.

This pull request removes 4079 and adds 1 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.ec2.test_ec2 ‑ test_raise_create_volume_without_size

♻️ This comment has been updated with latest results.

@nik-localstack nik-localstack force-pushed the fix/ec2/ebs-volume-without-size branch from c56c616 to 11e4d01 Compare February 21, 2025 15:14
@nik-localstack nik-localstack added this to the 4.3 milestone Feb 21, 2025
@nik-localstack
Add test for EBS volume creation without size
c80b547 
To be merged after moto v5.0.29 is merged into moto-ext
Related moto changes getmoto/moto#8556
@nik-localstack nik-localstack force-pushed the fix/ec2/ebs-volume-without-size branch from 11e4d01 to c80b547 Compare February 21, 2025 15:48
@nik-localstack nik-localstack marked this pull request as ready for review February 24, 2025 08:19
viren-nadkarni
viren-nadkarni approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@viren-nadkarni viren-nadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Thanks for adding this

@nik-localstack nik-localstack merged commit 8b5cedd into master Feb 24, 2025
31 checks passed
@nik-localstack nik-localstack deleted the fix/ec2/ebs-volume-without-size branch February 24, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@localstack-bot localstack-bot localstack-bot left review comments

@viren-nadkarni viren-nadkarni viren-nadkarni approved these changes

@macnev2013 macnev2013 Awaiting requested review from macnev2013 macnev2013 is a code owner

Assignees

@nik-localstack nik-localstack

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@nik-localstack @localstack-bot @viren-nadkarni