Skip to content

Add Lambda@Edge service principal #12313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Conversation

joe4dev
Copy link
Member

@joe4dev joe4dev commented Feb 27, 2025

Motivation

We are missing a service principal definition for edgelambda.amazonaws.com used at Lambda@Edge https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/lambda-edge-permissions.html

Changes

  • Add edgelambda to the list of service principals

@joe4dev joe4dev added the semver: patch Non-breaking changes which can be included in patch releases label Feb 27, 2025
@joe4dev joe4dev self-assigned this Feb 27, 2025
@joe4dev joe4dev requested review from dfangl and bentsku February 27, 2025 11:04
Copy link
Contributor

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I wonder if we could try to find a list somewhere of all possible principals 😄

@joe4dev
Copy link
Member Author

joe4dev commented Feb 27, 2025

LGTM! I wonder if we could try to find a list somewhere of all possible principals 😄

That might be a starting point (unofficial list): https://gist.github.com/shortjared/4c1e3fe52bdfa47522cfe5b41e5d6f22
I guess the question is should we add them proactively (makes it easier to add) or reactively (the list reflects what's used) :)

Copy link

LocalStack Community integration with Pro

    2 files      2 suites   1h 54m 39s ⏱️
4 104 tests 3 772 ✅ 332 💤 0 ❌
4 106 runs  3 772 ✅ 334 💤 0 ❌

Results for commit d8b152b.

@joe4dev joe4dev merged commit 8cf2f63 into master Feb 27, 2025
36 checks passed
@joe4dev joe4dev deleted the add-lambda-at-edge-service-principal branch February 27, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants