Skip to content

Fix Invalid noqa Usage in Step Functions TestState Preprocessor #12368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2025
Merged

Fix Invalid noqa Usage in Step Functions TestState Preprocessor #12368

merged 1 commit into from
Mar 12, 2025

Conversation

MEPalma
Copy link
Contributor

@MEPalma MEPalma commented Mar 11, 2025

Motivation

We are getting some linter warning in the TestState preprocessor for Step Functions due to the misuse of # noqa.

Changes

The changes move the noqa motivations to their separate comments.

@MEPalma MEPalma added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Mar 11, 2025
@MEPalma MEPalma added this to the 4.3 milestone Mar 11, 2025
@MEPalma MEPalma requested a review from silv-io March 11, 2025 19:41
@MEPalma MEPalma self-assigned this Mar 11, 2025
@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   31m 5s ⏱️ - 1h 22m 56s
1 450 tests  - 2 675  1 377 ✅  - 2 428  73 💤  - 247  0 ❌ ±0 
1 452 runs   - 2 675  1 377 ✅  - 2 428  75 💤  - 247  0 ❌ ±0 

Results for commit 62ffa37. ± Comparison against base commit 4f210f8.

This pull request removes 2675 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

silv-io
silv-io approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member

@silv-io silv-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these! LGTM

@MEPalma MEPalma merged commit 4f0b6ff into master Mar 12, 2025
36 checks passed
@MEPalma MEPalma deleted the MEP-SFN-fix_noqa branch March 12, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silv-io silv-io silv-io approved these changes

Assignees

@MEPalma MEPalma

Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@MEPalma @silv-io