APIGW: fix rendering of $input.body when empty #12413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67acd30 to
8c97dfb
Compare
cloutierMat
approved these changes
Mar 19, 2025
| for rest_api_id, _client_region_name in rest_apis: | ||
| apigateway_client = aws_client_factory( | ||
| region_name=_client_region_name, | ||
| config=retry_boto_config, |
| "recorded-date": "19-03-2025, 17:03:40", | ||
| "recorded-content": { | ||
| "response-raw-body": { | ||
| "empty-body": "b'{}'", |
There was a problem hiding this comment.
hmmm! interesting! nice find
| "response-body-attr-access": { | ||
| "empty-body": "b'{}'", | ||
| "json-body": "b'{}'", | ||
| "str-body": "b'{}'" |
There was a problem hiding this comment.
I was trying to expect what would come out of it... not what I thought! 🤣
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We broke an upstream integration test following #12322, because API Gateway would forward an empty body to the SQS integration, and SQS disallows that.
This is because API Gateway will replace an empty body with
{}when using$input.bodyin a VTL template.I've added a few tests validating the assumption, and @dfangl added the SQS regression test to make sure we don't break upstream anymore. He also added some changes in the retry mechanism for deleting REST APIs, and I've updated it to use the Boto config in both creation and deletion of REST APIs.
note: I've also tried with a request template set with
text/htmland the empty body is still{}so it's not dependent on the content-type.Changes
{}string if the body is empty for$input.body(so that it can be passed to function like$util.urlEncode)