Skip to content

fix cfn security group read #12414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025
Merged

fix cfn security group read #12414

merged 1 commit into from
Mar 20, 2025

Conversation

cloutierMat
Copy link
Contributor

@cloutierMat cloutierMat commented Mar 19, 2025

Motivation

With #12408 I broke the upstream pipeline. Tests for the read operation are only ran in the upstream repo so I missed that the tags are only added when there are tags present.

Changes

  • Add tags to read response only when they are not empty

@cloutierMat cloutierMat self-assigned this Mar 19, 2025
@cloutierMat cloutierMat added semver: patch Non-breaking changes which can be included in patch releases aws:cloudformation AWS CloudFormation aws:ec2 Amazon Elastic Compute Cloud labels Mar 19, 2025
Copy link

github-actions bot commented Mar 19, 2025

LocalStack Community integration with Pro

 2 files   2 suites   33s ⏱️
23 tests 21 ✅ 2 💤 0 ❌
25 runs  21 ✅ 4 💤 0 ❌

Results for commit 64938db.

♻️ This comment has been updated with latest results.

@cloutierMat cloutierMat marked this pull request as ready for review March 19, 2025 22:35
@cloutierMat cloutierMat requested a review from pinzon March 19, 2025 22:35
Copy link
Member

@pinzon pinzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cloutierMat cloutierMat force-pushed the fix/cloudformation-sg-tags-read branch from 893fc17 to c9ffc9f Compare March 19, 2025 23:05
@bentsku bentsku force-pushed the fix/cloudformation-sg-tags-read branch from c9ffc9f to 64938db Compare March 20, 2025 11:28
@bentsku
Copy link
Contributor

bentsku commented Mar 20, 2025

Merging to fix the pipeline, manually validated that it works 👍

@bentsku bentsku merged commit 310acf4 into master Mar 20, 2025
31 checks passed
@bentsku bentsku deleted the fix/cloudformation-sg-tags-read branch March 20, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws:cloudformation AWS CloudFormation aws:ec2 Amazon Elastic Compute Cloud semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants