Skip to content

Run tests on PRs against all branches #12418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025
Merged

Conversation

nik-localstack
Copy link
Contributor

Motivation

Sometimes, Pull Requests are open against branches other than master (eg stacked PRs)
In this case the tests don't currently run against in CI.

Changes

Allow the CI tests to run on all PRs.

@nik-localstack nik-localstack self-assigned this Mar 20, 2025
Copy link

Helper Script Tests

28 tests   28 ✅  0s ⏱️
 2 suites   0 💤
 1 files     0 ❌

Results for commit 06f68c7.

@nik-localstack nik-localstack added the semver: patch Non-breaking changes which can be included in patch releases label Mar 20, 2025
@nik-localstack nik-localstack marked this pull request as ready for review March 20, 2025 10:22
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks a lot for being proactive and suggesting changes to the pipeline configuration! The changes are looking good! Let's test all the branches and enable chained PR workflows when necessary! 🚀

@nik-localstack nik-localstack merged commit 632fca9 into master Mar 20, 2025
29 of 32 checks passed
@nik-localstack nik-localstack deleted the run-tests-on-all-branches branch March 20, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants