Apigw/add support for response override in request #12628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalStack Community integration with Pro 2 files 2 suites 19m 8s ⏱️ Results for commit 38d05a2. ♻️ This comment has been updated with latest results. |
… parser to prevent if block everywhere
cloutierMat
commented
May 16, 2025
| @@ -159,6 +159,7 @@ def create_test_invocation_context( | |||
| requestOverride=ContextVarsRequestOverride(header={}, path={}, querystring={}), | |||
| responseOverride=ContextVarsResponseOverride(header={}, status=0), | |||
| ) | |||
| invocation_context.trace_id = parse_handler.populate_trace_id({}) | |||
There was a problem hiding this comment.
it had been deleted in the previous commit, I've just added it back 😄 bb5dbe1
bentsku
approved these changes
May 16, 2025
There was a problem hiding this comment.
LGTM! This looks good, quite a really weird case by AWS 👀
It's also funny that we can add user-defined fields to the responseOverride, acting like a context stash for user-defined values...
That must have been a fun one 😄 thanks for added parity and jumping on this! 🚀
| @@ -159,6 +159,7 @@ def create_test_invocation_context( | |||
| requestOverride=ContextVarsRequestOverride(header={}, path={}, querystring={}), | |||
| responseOverride=ContextVarsResponseOverride(header={}, status=0), | |||
| ) | |||
| invocation_context.trace_id = parse_handler.populate_trace_id({}) | |||
There was a problem hiding this comment.
it had been deleted in the previous commit, I've just added it back 😄 bb5dbe1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a partial solve for #12621.
This pr will allow to use
responseOverridein a request template and have it's value passed to the context of the response template and possibly affecting the response.There are 2 issues described by the user. I will work on the VTL template update in a follow up.
Changes