Skip to content

CloudFormation v2 Engine: Support for Fn::Select #12679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: MEP-CFN-aws_novalue
Choose a base branch
from
Open

CloudFormation v2 Engine: Support for Fn::Select #12679

wants to merge 2 commits into from

Conversation

MEPalma
Copy link
Contributor

@MEPalma MEPalma commented May 28, 2025

* Extends #12668

Motivation

The introduction of the CloudFormation v2 engine laid the foundation for a redesigned engine capable of accurately determining update requirements between CloudFormation deployments, while also enabling parallel execution during updates. However, the current implementation offers no support for Fn::Select.

Changes

  • Added change set modeling, description, and execution support for Fn::Select
  • Added an initial set of boundary tests for template updates concerning the use of Fn::Select
  • Unblocked or updated skip annotation for related v1 tests

@MEPalma MEPalma added this to the 4.5 milestone May 28, 2025
@MEPalma MEPalma requested a review from simonrw May 28, 2025 19:16
@MEPalma MEPalma self-assigned this May 28, 2025
@MEPalma MEPalma added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label May 28, 2025
@github-actions GitHub Actions
Copy link

Test Results - Preflight, Unit

21 601 tests  ±0   19 955 ✅ ±0   6m 7s ⏱️ -4s
     1 suites ±0    1 646 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 2833ff3. ± Comparison against base commit 52008ee.

@github-actions GitHub Actions
Copy link

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 6s ⏱️ -3s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 2833ff3. ± Comparison against base commit 52008ee.

@github-actions GitHub Actions
Copy link

Test Results - Alternative Providers

977 tests  +6   546 ✅ +7   21m 30s ⏱️ +18s
  4 suites ±0   431 💤  - 1 
  4 files   ±0     0 ❌ ±0 

Results for commit 2833ff3. ± Comparison against base commit 52008ee.

@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

  2 files  ±0    2 suites  ±0   20m 44s ⏱️ -37s
875 tests +6  318 ✅  - 1  557 💤 +7  0 ❌ ±0 
877 runs  +6  318 ✅  - 1  559 💤 +7  0 ❌ ±0 

Results for commit 2833ff3. ± Comparison against base commit 52008ee.

@github-actions GitHub Actions
Copy link

Test Results (amd64) - Integration, Bootstrap

    5 files  ±0      5 suites  ±0   2h 23m 29s ⏱️ - 3m 40s
5 198 tests +6  4 279 ✅  - 1  919 💤 +7  0 ❌ ±0 
5 204 runs  +6  4 279 ✅  - 1  925 💤 +7  0 ❌ ±0 

Results for commit 2833ff3. ± Comparison against base commit 52008ee.

simonrw
simonrw approved these changes May 29, 2025
View reviewed changes
Copy link
Contributor

@simonrw simonrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these. These new intrinsic support prs are quite easy to follow and targeted. A testament to the stability of the core concept

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonrw simonrw simonrw approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

@pinzon pinzon Awaiting requested review from pinzon pinzon is a code owner

Assignees

@MEPalma MEPalma

Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.
2 participants
@MEPalma @simonrw