From 87a28321bf8fb63b3f459e6a3ea9beecb83a75aa Mon Sep 17 00:00:00 2001 From: Benjamin Simon Date: Mon, 1 Sep 2025 15:36:16 +0200 Subject: [PATCH 01/23] fix alternative providers publishing not being executed --- .github/workflows/aws-tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/aws-tests.yml b/.github/workflows/aws-tests.yml index cd4ec7c2d71e4..61b042ad9eb3e 100644 --- a/.github/workflows/aws-tests.yml +++ b/.github/workflows/aws-tests.yml @@ -913,8 +913,8 @@ jobs: pull-requests: write contents: read issues: read - # execute on success or failure, but not if the workflow is cancelled or any of the dependencies has been skipped - if: always() && !cancelled() && !contains(needs.*.result, 'skipped') + # execute on success or failure, but not if the workflow is cancelled or all of the dependencies has been skipped + if: always() && !cancelled() && (contains(needs.*.result, 'success') || contains(needs.*.result, 'failure')) steps: - name: Download Cloudformation v2 Artifacts uses: actions/download-artifact@v5 From 481946db7221074a7f501f8d3da8e8d4dc7a6b74 Mon Sep 17 00:00:00 2001 From: Benjamin Simon Date: Mon, 1 Sep 2025 15:37:44 +0200 Subject: [PATCH 02/23] TODO: REMOVE, TRIGGER FOR PIPELINE --- localstack-core/localstack/services/cloudwatch/provider.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/localstack-core/localstack/services/cloudwatch/provider.py b/localstack-core/localstack/services/cloudwatch/provider.py index 0f5d705a7b780..4a56f8fd87592 100644 --- a/localstack-core/localstack/services/cloudwatch/provider.py +++ b/localstack-core/localstack/services/cloudwatch/provider.py @@ -53,6 +53,8 @@ LOG = logging.getLogger(__name__) +# TODO: remove this, triggering CloudWatch v1 + @patch(target=Alarm.update_state) def update_state(target, self, reason, reason_data, state_value): From 02d7505fe3b094d3b82b6250d79210742762c868 Mon Sep 17 00:00:00 2001 From: Benjamin Simon Date: Mon, 1 Sep 2025 16:56:19 +0200 Subject: [PATCH 03/23] Revert "TODO: REMOVE, TRIGGER FOR PIPELINE" This reverts commit 06d7d631338cf01b483b7103eeb19593c3ebd91f. --- localstack-core/localstack/services/cloudwatch/provider.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/localstack-core/localstack/services/cloudwatch/provider.py b/localstack-core/localstack/services/cloudwatch/provider.py index 4a56f8fd87592..0f5d705a7b780 100644 --- a/localstack-core/localstack/services/cloudwatch/provider.py +++ b/localstack-core/localstack/services/cloudwatch/provider.py @@ -53,8 +53,6 @@ LOG = logging.getLogger(__name__) -# TODO: remove this, triggering CloudWatch v1 - @patch(target=Alarm.update_state) def update_state(target, self, reason, reason_data, state_value): From dec04db61be6148258e529f478f6e358679dd7b8 Mon Sep 17 00:00:00 2001 From: Benjamin Simon Date: Mon, 1 Sep 2025 17:25:11 +0200 Subject: [PATCH 04/23] debug --- .github/workflows/aws-tests.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/aws-tests.yml b/.github/workflows/aws-tests.yml index 61b042ad9eb3e..aed871deac531 100644 --- a/.github/workflows/aws-tests.yml +++ b/.github/workflows/aws-tests.yml @@ -913,8 +913,10 @@ jobs: pull-requests: write contents: read issues: read + env: + DEBUG_VAR_VISIBILITY: ${{ toJSON(needs.*.result) }} # execute on success or failure, but not if the workflow is cancelled or all of the dependencies has been skipped - if: always() && !cancelled() && (contains(needs.*.result, 'success') || contains(needs.*.result, 'failure')) + if: ${{ always() && !cancelled() && (contains(needs.*.result, 'success') || contains(needs.*.result, 'failure')) }} steps: - name: Download Cloudformation v2 Artifacts uses: actions/download-artifact@v5 From 0517e78245ad4ed85e44adea9ea9add73ac9cc1e Mon Sep 17 00:00:00 2001 From: Benjamin Simon Date: Mon, 1 Sep 2025 17:57:47 +0200 Subject: [PATCH 05/23] debug --- .github/workflows/aws-tests.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/aws-tests.yml b/.github/workflows/aws-tests.yml index aed871deac531..1a14c23c2241f 100644 --- a/.github/workflows/aws-tests.yml +++ b/.github/workflows/aws-tests.yml @@ -915,6 +915,8 @@ jobs: issues: read env: DEBUG_VAR_VISIBILITY: ${{ toJSON(needs.*.result) }} + DEBUG_VAR_VISIBILITY2: ${{ contains(needs.*.result, 'success') || contains(needs.*.result, 'failure') }} + DEBUG_VAR_VISIBILITY3: ${{ always() && !cancelled() && (contains(needs.*.result, 'success') || contains(needs.*.result, 'failure')) }} # execute on success or failure, but not if the workflow is cancelled or all of the dependencies has been skipped if: ${{ always() && !cancelled() && (contains(needs.*.result, 'success') || contains(needs.*.result, 'failure')) }} steps: From 6516422b1fb80d9f2aa46b2803817070f1bc0d28 Mon Sep 17 00:00:00 2001 From: Benjamin Simon Date: Mon, 1 Sep 2025 17:59:46 +0200 Subject: [PATCH 06/23] debug --- .github/workflows/aws-tests.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/aws-tests.yml b/.github/workflows/aws-tests.yml index 1a14c23c2241f..dd2c91c71c188 100644 --- a/.github/workflows/aws-tests.yml +++ b/.github/workflows/aws-tests.yml @@ -914,7 +914,8 @@ jobs: contents: read issues: read env: - DEBUG_VAR_VISIBILITY: ${{ toJSON(needs.*.result) }} + DEBUG_VAR_VISIBILITY0: ${{ toJSON(needs) }} + DEBUG_VAR_VISIBILITY1: ${{ toJSON(needs.*.result) }} DEBUG_VAR_VISIBILITY2: ${{ contains(needs.*.result, 'success') || contains(needs.*.result, 'failure') }} DEBUG_VAR_VISIBILITY3: ${{ always() && !cancelled() && (contains(needs.*.result, 'success') || contains(needs.*.result, 'failure')) }} # execute on success or failure, but not if the workflow is cancelled or all of the dependencies has been skipped From 193e5c310f10e085bb4d12df80703eb9cad30239 Mon Sep 17 00:00:00 2001 From: Benjamin Simon Date: Mon, 1 Sep 2025 18:02:23 +0200 Subject: [PATCH 07/23] debug? gotta love GH actions --- .github/workflows/aws-tests.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/aws-tests.yml b/.github/workflows/aws-tests.yml index dd2c91c71c188..dcf47c7d0ca73 100644 --- a/.github/workflows/aws-tests.yml +++ b/.github/workflows/aws-tests.yml @@ -917,7 +917,6 @@ jobs: DEBUG_VAR_VISIBILITY0: ${{ toJSON(needs) }} DEBUG_VAR_VISIBILITY1: ${{ toJSON(needs.*.result) }} DEBUG_VAR_VISIBILITY2: ${{ contains(needs.*.result, 'success') || contains(needs.*.result, 'failure') }} - DEBUG_VAR_VISIBILITY3: ${{ always() && !cancelled() && (contains(needs.*.result, 'success') || contains(needs.*.result, 'failure')) }} # execute on success or failure, but not if the workflow is cancelled or all of the dependencies has been skipped if: ${{ always() && !cancelled() && (contains(needs.*.result, 'success') || contains(needs.*.result, 'failure')) }} steps: From eb5e9c5ecb6b23382e12e63801bb4805457610fb Mon Sep 17 00:00:00 2001 From: Benjamin Simon Date: Mon, 1 Sep 2025 18:19:15 +0200 Subject: [PATCH 08/23] =?UTF-8?q?(=E2=95=AF=C2=B0=E2=96=A1=C2=B0)=E2=95=AF?= =?UTF-8?q?=EF=B8=B5=20=E2=94=BB=E2=94=81=E2=94=BB?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/aws-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/aws-tests.yml b/.github/workflows/aws-tests.yml index dcf47c7d0ca73..2bebcfebcf3a0 100644 --- a/.github/workflows/aws-tests.yml +++ b/.github/workflows/aws-tests.yml @@ -916,7 +916,7 @@ jobs: env: DEBUG_VAR_VISIBILITY0: ${{ toJSON(needs) }} DEBUG_VAR_VISIBILITY1: ${{ toJSON(needs.*.result) }} - DEBUG_VAR_VISIBILITY2: ${{ contains(needs.*.result, 'success') || contains(needs.*.result, 'failure') }} + DEBUG_VAR_VISIBILITY2: ${{ true && (contains(needs.*.result, 'success') || contains(needs.*.result, 'failure')) }} # execute on success or failure, but not if the workflow is cancelled or all of the dependencies has been skipped if: ${{ always() && !cancelled() && (contains(needs.*.result, 'success') || contains(needs.*.result, 'failure')) }} steps: From 3a2b4496dcc9f3b3f5a61052fc6f9b16eadc8eba Mon Sep 17 00:00:00 2001 From: Benjamin Simon Date: Mon, 1 Sep 2025 18:46:47 +0200 Subject: [PATCH 09/23] patience --- .github/workflows/aws-tests.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/aws-tests.yml b/.github/workflows/aws-tests.yml index 2bebcfebcf3a0..75950d6df13ab 100644 --- a/.github/workflows/aws-tests.yml +++ b/.github/workflows/aws-tests.yml @@ -913,12 +913,8 @@ jobs: pull-requests: write contents: read issues: read - env: - DEBUG_VAR_VISIBILITY0: ${{ toJSON(needs) }} - DEBUG_VAR_VISIBILITY1: ${{ toJSON(needs.*.result) }} - DEBUG_VAR_VISIBILITY2: ${{ true && (contains(needs.*.result, 'success') || contains(needs.*.result, 'failure')) }} # execute on success or failure, but not if the workflow is cancelled or all of the dependencies has been skipped - if: ${{ always() && !cancelled() && (contains(needs.*.result, 'success') || contains(needs.*.result, 'failure')) }} + if: ${{ !cancelled() && ( contains(needs.*.result, 'success') || contains(needs.*.result, 'failure') ) }} steps: - name: Download Cloudformation v2 Artifacts uses: actions/download-artifact@v5 From a8ac708247fca6402cd76ee4a870ac3bcd418f9a Mon Sep 17 00:00:00 2001 From: Benjamin Simon Date: Mon, 1 Sep 2025 19:02:38 +0200 Subject: [PATCH 10/23] patience again --- .github/workflows/aws-tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/aws-tests.yml b/.github/workflows/aws-tests.yml index 75950d6df13ab..7bf4c7760c8d4 100644 --- a/.github/workflows/aws-tests.yml +++ b/.github/workflows/aws-tests.yml @@ -901,6 +901,8 @@ jobs: publish-alternative-provider-test-results: name: Publish Alternative Provider Test Results + # execute on success or failure, but not if the workflow is cancelled or all of the dependencies has been skipped + if: ${{ !inputs.onlyAcceptanceTests && !cancelled() && ( contains(needs.*.result, 'success') || contains(needs.*.result, 'failure') ) }} needs: - test-cfn-v2-engine - test-events-v1 @@ -913,8 +915,6 @@ jobs: pull-requests: write contents: read issues: read - # execute on success or failure, but not if the workflow is cancelled or all of the dependencies has been skipped - if: ${{ !cancelled() && ( contains(needs.*.result, 'success') || contains(needs.*.result, 'failure') ) }} steps: - name: Download Cloudformation v2 Artifacts uses: actions/download-artifact@v5 From 7894b71840168f70da0e50f039e406666301288f Mon Sep 17 00:00:00 2001 From: Benjamin Simon Date: Mon, 1 Sep 2025 19:19:28 +0200 Subject: [PATCH 11/23] just trying things --- .github/workflows/aws-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/aws-tests.yml b/.github/workflows/aws-tests.yml index 7bf4c7760c8d4..b699aa29d0afc 100644 --- a/.github/workflows/aws-tests.yml +++ b/.github/workflows/aws-tests.yml @@ -902,7 +902,7 @@ jobs: publish-alternative-provider-test-results: name: Publish Alternative Provider Test Results # execute on success or failure, but not if the workflow is cancelled or all of the dependencies has been skipped - if: ${{ !inputs.onlyAcceptanceTests && !cancelled() && ( contains(needs.*.result, 'success') || contains(needs.*.result, 'failure') ) }} + if: ${{ !cancelled() && false && ( contains(needs.*.result, 'success') || contains(needs.*.result, 'failure') ) }} needs: - test-cfn-v2-engine - test-events-v1 From c18309f7161fcf53a4fbcd0f9265013071c17563 Mon Sep 17 00:00:00 2001 From: Benjamin Simon Date: Tue, 2 Sep 2025 12:28:30 +0200 Subject: [PATCH 12/23] just trying things --- .github/workflows/aws-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/aws-tests.yml b/.github/workflows/aws-tests.yml index b699aa29d0afc..87ead19606814 100644 --- a/.github/workflows/aws-tests.yml +++ b/.github/workflows/aws-tests.yml @@ -902,7 +902,7 @@ jobs: publish-alternative-provider-test-results: name: Publish Alternative Provider Test Results # execute on success or failure, but not if the workflow is cancelled or all of the dependencies has been skipped - if: ${{ !cancelled() && false && ( contains(needs.*.result, 'success') || contains(needs.*.result, 'failure') ) }} + if: ${{ !cancelled() && ( contains(needs.*.result, 'success') || contains(needs.*.result, 'failure') ) }} needs: - test-cfn-v2-engine - test-events-v1 From f1f6a5f25d78ed6569f35f16d8e5137bc12c6c13 Mon Sep 17 00:00:00 2001 From: Benjamin Simon Date: Tue, 2 Sep 2025 17:49:04 +0200 Subject: [PATCH 13/23] try no parenthesis --- .github/workflows/aws-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/aws-tests.yml b/.github/workflows/aws-tests.yml index 87ead19606814..7d0db701717ab 100644 --- a/.github/workflows/aws-tests.yml +++ b/.github/workflows/aws-tests.yml @@ -902,7 +902,7 @@ jobs: publish-alternative-provider-test-results: name: Publish Alternative Provider Test Results # execute on success or failure, but not if the workflow is cancelled or all of the dependencies has been skipped - if: ${{ !cancelled() && ( contains(needs.*.result, 'success') || contains(needs.*.result, 'failure') ) }} + if: ${{ !cancelled() && contains(needs.*.result, 'success') }} needs: - test-cfn-v2-engine - test-events-v1 From a20b65b10732435d2bbb335908b015a7898c3858 Mon Sep 17 00:00:00 2001 From: Benjamin Simon Date: Tue, 2 Sep 2025 18:17:51 +0200 Subject: [PATCH 14/23] debug --- .github/workflows/aws-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/aws-tests.yml b/.github/workflows/aws-tests.yml index 7d0db701717ab..0f22be2e721e8 100644 --- a/.github/workflows/aws-tests.yml +++ b/.github/workflows/aws-tests.yml @@ -902,7 +902,7 @@ jobs: publish-alternative-provider-test-results: name: Publish Alternative Provider Test Results # execute on success or failure, but not if the workflow is cancelled or all of the dependencies has been skipped - if: ${{ !cancelled() && contains(needs.*.result, 'success') }} + if: ${{ !cancelled() && contains(needs.*.result, 'bad value') }} needs: - test-cfn-v2-engine - test-events-v1 From 06f9c2af5a38cc06b42d403932d4ca4f2b2dd64d Mon Sep 17 00:00:00 2001 From: Benjamin Simon Date: Tue, 2 Sep 2025 18:49:53 +0200 Subject: [PATCH 15/23] replace checks manually --- .github/workflows/aws-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/aws-tests.yml b/.github/workflows/aws-tests.yml index 0f22be2e721e8..0c24a40c995a3 100644 --- a/.github/workflows/aws-tests.yml +++ b/.github/workflows/aws-tests.yml @@ -902,7 +902,7 @@ jobs: publish-alternative-provider-test-results: name: Publish Alternative Provider Test Results # execute on success or failure, but not if the workflow is cancelled or all of the dependencies has been skipped - if: ${{ !cancelled() && contains(needs.*.result, 'bad value') }} + if: ${{ !cancelled() && (contains(fromJSON('["success", "failure"]'), needs.test-cfn-v2-engine.result) || contains(fromJSON('["success", "failure"]'), needs.test-events-v1.result) || contains(fromJSON('["success", "failure"]'), needs.test-ddb-v2.result) || contains(fromJSON('["success", "failure"]'), needs.test-cloudwatch-v1.result)) }} needs: - test-cfn-v2-engine - test-events-v1 From 94f80a9f3d25c327ca5a05c953937e9a767b8a5d Mon Sep 17 00:00:00 2001 From: Benjamin Simon Date: Tue, 2 Sep 2025 22:03:56 +0200 Subject: [PATCH 16/23] test trigger --- localstack-core/localstack/services/events/v1/provider.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/localstack-core/localstack/services/events/v1/provider.py b/localstack-core/localstack/services/events/v1/provider.py index 9c0352a1aa76b..84eff16fa8a61 100644 --- a/localstack-core/localstack/services/events/v1/provider.py +++ b/localstack-core/localstack/services/events/v1/provider.py @@ -63,6 +63,8 @@ DEFAULT_EVENT_BUS_NAME = "default" CONNECTION_NAME_PATTERN = re.compile("^[\\.\\-_A-Za-z0-9]+$") +# TODO: remove, test trigger + class ValidationException(ServiceException): code: str = "ValidationException" From 873866542d404eec1a5d211bdaad5ef3f5f423fa Mon Sep 17 00:00:00 2001 From: Benjamin Simon Date: Tue, 2 Sep 2025 22:24:10 +0200 Subject: [PATCH 17/23] fix events-v1 CI detection --- .github/workflows/aws-tests.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/aws-tests.yml b/.github/workflows/aws-tests.yml index 0c24a40c995a3..34cc73ed5a2f5 100644 --- a/.github/workflows/aws-tests.yml +++ b/.github/workflows/aws-tests.yml @@ -271,6 +271,7 @@ jobs: - 'tests/aws/services/dynamodbstreams/**' - 'tests/aws/services/lambda_/event_source_mapping/test_lambda_integration_dynamodbstreams.py' events-v1: + - 'localstack-core/localstack/services/events/**' - 'tests/aws/services/events/**' cloudformation-v2: - 'tests/aws/services/cloudformation/**' From 2d6522ef92cc2a97c8a3ea753beb5170a18fce4c Mon Sep 17 00:00:00 2001 From: Benjamin Simon Date: Tue, 2 Sep 2025 22:25:25 +0200 Subject: [PATCH 18/23] improve all service detection --- .github/workflows/aws-tests.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/aws-tests.yml b/.github/workflows/aws-tests.yml index 34cc73ed5a2f5..cdc689bb16249 100644 --- a/.github/workflows/aws-tests.yml +++ b/.github/workflows/aws-tests.yml @@ -267,6 +267,7 @@ jobs: - 'localstack-core/localstack/services/cloudwatch/**' - 'tests/aws/services/cloudwatch/**' dynamodb-v2: + - 'localstack-core/localstack/services/dynamodb/**' - 'tests/aws/services/dynamodb/**' - 'tests/aws/services/dynamodbstreams/**' - 'tests/aws/services/lambda_/event_source_mapping/test_lambda_integration_dynamodbstreams.py' @@ -274,6 +275,7 @@ jobs: - 'localstack-core/localstack/services/events/**' - 'tests/aws/services/events/**' cloudformation-v2: + - 'localstack-core/localstack/services/cloudformation/**' - 'tests/aws/services/cloudformation/**' sns-v2: - 'tests/aws/services/sns/**' # todo: potentially add more locations (lambda/sqs tests?) From af4b5dbe77ef1b03dcd3e0f158d14c0d144a1df0 Mon Sep 17 00:00:00 2001 From: Benjamin Simon Date: Tue, 2 Sep 2025 23:01:02 +0200 Subject: [PATCH 19/23] Revert "test trigger" This reverts commit fb530fdb48217bd3d626b6b2ed77e59d27f8145e. --- localstack-core/localstack/services/events/v1/provider.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/localstack-core/localstack/services/events/v1/provider.py b/localstack-core/localstack/services/events/v1/provider.py index 84eff16fa8a61..9c0352a1aa76b 100644 --- a/localstack-core/localstack/services/events/v1/provider.py +++ b/localstack-core/localstack/services/events/v1/provider.py @@ -63,8 +63,6 @@ DEFAULT_EVENT_BUS_NAME = "default" CONNECTION_NAME_PATTERN = re.compile("^[\\.\\-_A-Za-z0-9]+$") -# TODO: remove, test trigger - class ValidationException(ServiceException): code: str = "ValidationException" From 17a8c54a317545321912c117072344c46b621209 Mon Sep 17 00:00:00 2001 From: Benjamin Simon Date: Thu, 4 Sep 2025 15:21:55 +0200 Subject: [PATCH 20/23] TBD: trying things out --- .github/workflows/aws-tests.yml | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/.github/workflows/aws-tests.yml b/.github/workflows/aws-tests.yml index cdc689bb16249..2513e9d4fc761 100644 --- a/.github/workflows/aws-tests.yml +++ b/.github/workflows/aws-tests.yml @@ -668,6 +668,8 @@ jobs: # Set job-specific environment variables for pytest-tinybird CI_JOB_NAME: ${{ github.job }} CI_JOB_ID: ${{ github.job }} + outputs: + job_status: "executed" steps: - name: Checkout uses: actions/checkout@v5 @@ -718,6 +720,8 @@ jobs: # Set job-specific environment variables for pytest-tinybird CI_JOB_NAME: ${{ github.job }} CI_JOB_ID: ${{ github.job }} + outputs: + job_status: "executed" steps: - name: Checkout uses: actions/checkout@v5 @@ -767,6 +771,8 @@ jobs: # Set job-specific environment variables for pytest-tinybird CI_JOB_NAME: ${{ github.job }} CI_JOB_ID: ${{ github.job }} + outputs: + job_status: "executed" steps: - name: Checkout uses: actions/checkout@v5 @@ -818,6 +824,8 @@ jobs: # Set job-specific environment variables for pytest-tinybird CI_JOB_NAME: ${{ github.job }} CI_JOB_ID: ${{ github.job }} + outputs: + job_status: "executed" steps: - name: Checkout uses: actions/checkout@v5 @@ -852,6 +860,7 @@ jobs: ${{ env.COVERAGE_FILE }} ${{ env.JUNIT_REPORTS_FILE }} retention-days: 30 + test-sns-v2: name: Test SNS V2 if: ${{ !inputs.onlyAcceptanceTests && (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/tags/v') || needs.test-preflight.outputs.sns-v2 == 'true') }} @@ -864,6 +873,8 @@ jobs: # Set job-specific environment variables for pytest-tinybird CI_JOB_NAME: ${{ github.job }} CI_JOB_ID: ${{ github.job }} + outputs: + job_status: "executed" steps: - name: Checkout uses: actions/checkout@v5 @@ -905,7 +916,8 @@ jobs: publish-alternative-provider-test-results: name: Publish Alternative Provider Test Results # execute on success or failure, but not if the workflow is cancelled or all of the dependencies has been skipped - if: ${{ !cancelled() && (contains(fromJSON('["success", "failure"]'), needs.test-cfn-v2-engine.result) || contains(fromJSON('["success", "failure"]'), needs.test-events-v1.result) || contains(fromJSON('["success", "failure"]'), needs.test-ddb-v2.result) || contains(fromJSON('["success", "failure"]'), needs.test-cloudwatch-v1.result)) }} + # if: ${{ !cancelled() && (contains(fromJSON('["success", "failure"]'), needs.test-cfn-v2-engine.result) || contains(fromJSON('["success", "failure"]'), needs.test-events-v1.result) || contains(fromJSON('["success", "failure"]'), needs.test-ddb-v2.result) || contains(fromJSON('["success", "failure"]'), needs.test-cloudwatch-v1.result)) }} + if: ${{ !cancelled() && (contains(needs.*.outputs.job_status, 'executed')) }} needs: - test-cfn-v2-engine - test-events-v1 From 51093963fc0a2565dbe36ef88f73bfe1af6997bc Mon Sep 17 00:00:00 2001 From: Benjamin Simon Date: Thu, 4 Sep 2025 20:43:29 +0200 Subject: [PATCH 21/23] Revert "Revert "test trigger"" This reverts commit af4b5dbe77ef1b03dcd3e0f158d14c0d144a1df0. --- localstack-core/localstack/services/events/v1/provider.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/localstack-core/localstack/services/events/v1/provider.py b/localstack-core/localstack/services/events/v1/provider.py index 9c0352a1aa76b..84eff16fa8a61 100644 --- a/localstack-core/localstack/services/events/v1/provider.py +++ b/localstack-core/localstack/services/events/v1/provider.py @@ -63,6 +63,8 @@ DEFAULT_EVENT_BUS_NAME = "default" CONNECTION_NAME_PATTERN = re.compile("^[\\.\\-_A-Za-z0-9]+$") +# TODO: remove, test trigger + class ValidationException(ServiceException): code: str = "ValidationException" From 0b468defaca430f73efe9c1e5adbba3115a35f4a Mon Sep 17 00:00:00 2001 From: Benjamin Simon Date: Thu, 4 Sep 2025 21:04:49 +0200 Subject: [PATCH 22/23] Revert "Revert "Revert "test trigger""" This reverts commit 51093963fc0a2565dbe36ef88f73bfe1af6997bc. --- localstack-core/localstack/services/events/v1/provider.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/localstack-core/localstack/services/events/v1/provider.py b/localstack-core/localstack/services/events/v1/provider.py index 84eff16fa8a61..9c0352a1aa76b 100644 --- a/localstack-core/localstack/services/events/v1/provider.py +++ b/localstack-core/localstack/services/events/v1/provider.py @@ -63,8 +63,6 @@ DEFAULT_EVENT_BUS_NAME = "default" CONNECTION_NAME_PATTERN = re.compile("^[\\.\\-_A-Za-z0-9]+$") -# TODO: remove, test trigger - class ValidationException(ServiceException): code: str = "ValidationException" From a04930fd53d8e28374f9e372e1698aba3ea8dea7 Mon Sep 17 00:00:00 2001 From: Benjamin Simon Date: Thu, 4 Sep 2025 21:06:13 +0200 Subject: [PATCH 23/23] remove comments --- .github/workflows/aws-tests.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/aws-tests.yml b/.github/workflows/aws-tests.yml index 2513e9d4fc761..badcb8ec6c17b 100644 --- a/.github/workflows/aws-tests.yml +++ b/.github/workflows/aws-tests.yml @@ -669,6 +669,7 @@ jobs: CI_JOB_NAME: ${{ github.job }} CI_JOB_ID: ${{ github.job }} outputs: + # we need this output to conditionally execute the Publishing step job_status: "executed" steps: - name: Checkout @@ -721,6 +722,7 @@ jobs: CI_JOB_NAME: ${{ github.job }} CI_JOB_ID: ${{ github.job }} outputs: + # we need this output to conditionally execute the Publishing step job_status: "executed" steps: - name: Checkout @@ -772,6 +774,7 @@ jobs: CI_JOB_NAME: ${{ github.job }} CI_JOB_ID: ${{ github.job }} outputs: + # we need this output to conditionally execute the Publishing step job_status: "executed" steps: - name: Checkout @@ -825,6 +828,7 @@ jobs: CI_JOB_NAME: ${{ github.job }} CI_JOB_ID: ${{ github.job }} outputs: + # we need this output to conditionally execute the Publishing step job_status: "executed" steps: - name: Checkout @@ -874,6 +878,7 @@ jobs: CI_JOB_NAME: ${{ github.job }} CI_JOB_ID: ${{ github.job }} outputs: + # we need this output to conditionally execute the Publishing step job_status: "executed" steps: - name: Checkout @@ -916,7 +921,6 @@ jobs: publish-alternative-provider-test-results: name: Publish Alternative Provider Test Results # execute on success or failure, but not if the workflow is cancelled or all of the dependencies has been skipped - # if: ${{ !cancelled() && (contains(fromJSON('["success", "failure"]'), needs.test-cfn-v2-engine.result) || contains(fromJSON('["success", "failure"]'), needs.test-events-v1.result) || contains(fromJSON('["success", "failure"]'), needs.test-ddb-v2.result) || contains(fromJSON('["success", "failure"]'), needs.test-cloudwatch-v1.result)) }} if: ${{ !cancelled() && (contains(needs.*.outputs.job_status, 'executed')) }} needs: - test-cfn-v2-engine