fix(dropdown): aria-labbeledby for dropdowns

emanuelmutschlechner · emanuelmutschlechner · commit 8efa7ee3978b · 2018-04-21T06:01:00.000+02:00
diff --git a/src/components/dropdown/dropdown.js b/src/components/dropdown/dropdown.js
@@ -62,7 +62,7 @@ export default {
         class: this.menuClasses,
         attrs: {
           role: this.role,
-          'aria-labelledby': this.safeId(this.split ? '_BV_toggle_' : '_BV_button_')
+          'aria-labelledby': this.safeId(this.split ? '_BV_button_' : '_BV_toggle_')
         },
         on: {
           mouseover: this.onMouseOver,
diff --git a/src/components/dropdown/dropdown.spec.js b/src/components/dropdown/dropdown.spec.js
@@ -108,13 +108,22 @@ describe('dropdown', async () => {
     expect(Array.from(dd_6.$refs.menu.children).filter(node => node.classList.contains('dropdown-divider')).length).toBe(1)
   })
 
-  it('.dropdown menu aria-labelledby should target `_BV_button_` when not in split mode', async () => {
+  it('.dropdown menu aria-labelledby should target `_BV_toggle_` when not in split mode', async () => {
     const { app: { $refs } } = window
     const { dd_1 } = $refs // eslint-disable-line camelcase
 
     const menu = Array.from(dd_1.$el.children)
       .find(node => node.attributes.role && node.attributes.role.value === 'menu')
 
+    expect(menu.attributes['aria-labelledby'].value).toMatch(/_BV_toggle_$/)
+  })
+  it('.dropdown menu aria-labelledby should target `_BV_button_` when in split mode', async () => {
+    const { app: { $refs } } = window
+    const { dd_2 } = $refs // eslint-disable-line camelcase
+
+    const menu = Array.from(dd_2.$el.children)
+      .find(node => node.attributes.role && node.attributes.role.value === 'menu')
+
     expect(menu.attributes['aria-labelledby'].value).toMatch(/_BV_button_$/)
   })
 })
