Skip to content

Commit 68ae239

Browse files
ThomasVitaletzolov
authored andcommitted
Remove Logback from production JAR
Move Logback dependency to test scope to make it possible for applications using this library to choose their implementation of the SLF4J API. For example, Spring Boot provides one out of the box already. Fixes modelcontextprotocolgh-49 Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
1 parent 580f955 commit 68ae239

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

mcp/pom.xml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,6 @@
2727
<version>${slf4j-api.version}</version>
2828
</dependency>
2929

30-
<dependency>
31-
<groupId>ch.qos.logback</groupId>
32-
<artifactId>logback-classic</artifactId>
33-
<version>${logback.version}</version>
34-
</dependency>
35-
3630
<dependency>
3731
<groupId>com.fasterxml.jackson.core</groupId>
3832
<artifactId>jackson-databind</artifactId>
@@ -112,6 +106,13 @@
112106
<scope>test</scope>
113107
</dependency>
114108

109+
<dependency>
110+
<groupId>ch.qos.logback</groupId>
111+
<artifactId>logback-classic</artifactId>
112+
<version>${logback.version}</version>
113+
<scope>test</scope>
114+
</dependency>
115+
115116
</dependencies>
116117

117118

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@
7373
<testcontainers.version>1.20.4</testcontainers.version>
7474

7575
<slf4j-api.version>2.0.16</slf4j-api.version>
76-
<logback.version>1.5.12</logback.version>
76+
<logback.version>1.5.15</logback.version>
7777
<jackson.version>2.17.0</jackson.version>
7878
<springframework.version>6.2.1</springframework.version>
7979

0 commit comments

Comments
 (0)