-
Notifications
You must be signed in to change notification settings - Fork 181
Dropped network / db failover not supported because of pg@6.0.0 #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@robinbiondi , now that the PR #312 is merged, is this issue good to close? Thanks. |
@dhmlau , Yes. Good to close ! |
@dhmlau, Hello! Could you tell me when the fix of this issue will be available on an npm version ? |
@robinbiondi , sorry about the delay. It's been released as |
Hello @dhmlau, Shouldn't it be deployed as a 2.x version ? |
@robinbiondi , you're right!! Looking into it now. |
@robinbiondi, sorry about the confusion. The changes are now released as btw, do you have plans to move to 3.x? 2.x is currently in LTS, you'd get more recent bug fixes and better support in general for using 3.x. Please see http://loopback.io/doc/en/contrib/Long-term-support.html. |
@dhmlau No problem. Thank you. Yes, we are thinking about it. But we don't have much time for that right now. Maybe later. :) |
Description/Steps to reproduce
Hello, we use loopback 2 for 2 years in production and we recently encountered some issues regarding the connection to the DB. This issue concerns version 2.x of loopback-connector-postgres
We experienced some RDS fail-overs which is not a big deal. The problem is that the connections in the connector pool weren't released and after the failover, connections were still trying to reach the DB emiting CONNECTION TIMEOUT errors. The result is that all our servers go down.
In order to reproduce:
=> All the new requests will fail
Expected result
The normal behavior would be that the pool of connection goes empty and that new connections be created.
Additional information
We identified that this problem was caused by the library pg.
See the issue brianc/node-postgres#1075
This issue was fixed in this PR: brianc/node-postgres#1316
We saw that in version 3.x of loopback-connector-postgres, you decided to switch to pg@7
This would solve the problem here. We'd like to make a PR for that.
The text was updated successfully, but these errors were encountered: