Add existence check for dynamicParamsConfig

aq-ikhwa-tech · aq-ikhwa-tech · commit 2cc62cc0c83d · 2023-07-29T21:14:54.000+05:00
- Add an existence check to fix invalid traversal of dataSourceConfig.dynamicParamsConfig() in case of null dataSourceConfig.dynamicParamsConfig value
diff --git a/server/node-service/src/services/plugin.ts b/server/node-service/src/services/plugin.ts
@@ -214,7 +214,7 @@ export async function runPluginQuery(
 
   //forward cookies
   context.forEach(({ key, value }) => {
-    if (key in dataSourceConfig.dynamicParamsConfig) {
+    if (dataSourceConfig.dynamicParamsConfig && key in dataSourceConfig.dynamicParamsConfig) {
       const valueKey = `${key}.value`;
       dataSourceConfig.dynamicParamsConfig[valueKey] = value[0].value
     }

Original file line number	Diff line number	Diff line change
`@@ -214,7 +214,7 @@ export async function runPluginQuery(`
`214`	`214`
`215`	`215`	`//forward cookies`
`216`	`216`	`context.forEach(({ key, value }) => {`
`217`		`- if (key in dataSourceConfig.dynamicParamsConfig) {`
	`217`	`+ if (dataSourceConfig.dynamicParamsConfig && key in dataSourceConfig.dynamicParamsConfig) {`
`218`	`218`	const valueKey = `${key}.value`;
`219`	`219`	`dataSourceConfig.dynamicParamsConfig[valueKey] = value[0].value`
`220`	`220`	`}`