[Fix]: query deployment param

iamfaran · iamfaran · commit 5b542764e2f6 · 2025-05-29T21:37:34.000+05:00
diff --git a/client/packages/lowcoder/src/pages/setting/environments/config/query.config.tsx b/client/packages/lowcoder/src/pages/setting/environments/config/query.config.tsx
@@ -17,6 +17,12 @@ export const queryConfig: DeployableItemConfig = {
         label: 'Update Dependencies If Needed',
         type: 'checkbox',
         defaultValue: false
+      },
+      {
+        name: 'deployCredential',
+        label: 'Overwrite Credentials',
+        type: 'checkbox',
+        defaultValue: false
       }
     ],
     prepareParams: (item: Query, values: any, sourceEnv: Environment, targetEnv: Environment) => {
@@ -26,6 +32,7 @@ export const queryConfig: DeployableItemConfig = {
         queryId: item.id,
         updateDependenciesIfNeeded: values.updateDependenciesIfNeeded,
         queryGid: item.gid,
+        deployCredential: values.deployCredential ?? false
       };
     },
     execute: (params: any) => deployQuery(params)
diff --git a/client/packages/lowcoder/src/pages/setting/environments/config/workspace.config.tsx b/client/packages/lowcoder/src/pages/setting/environments/config/workspace.config.tsx
@@ -5,20 +5,13 @@ import { Environment } from '../types/environment.types';
 import { deployWorkspace } from '../services/workspace.service';
 import { Workspace } from '../types/workspace.types';
 
-
-
 export const workspaceConfig: DeployableItemConfig = {
   
   // Deploy configuration
   deploy: {
     singularLabel: 'Workspace',
     fields: [
-      {
-        name: 'deployCredential',
-        label: 'Overwrite Credentials',
-        type: 'checkbox',
-        defaultValue: false
-      }
+      // Removed deployCredential field as workspaces don't need credential overwrite
     ],
     prepareParams: (item: Workspace, values: any, sourceEnv: Environment, targetEnv: Environment) => {
       if (!item.gid) {
@@ -30,7 +23,7 @@ export const workspaceConfig: DeployableItemConfig = {
         envId: sourceEnv.environmentId,
         targetEnvId: targetEnv.environmentId,
         workspaceId: item.gid,
-        deployCredential: values.deployCredential ?? false
+        // Removed deployCredential parameter
       };
     },
     execute: (params: any) => deployWorkspace(params)
diff --git a/client/packages/lowcoder/src/pages/setting/environments/services/query.service.ts b/client/packages/lowcoder/src/pages/setting/environments/services/query.service.ts
@@ -16,6 +16,7 @@ export interface MergedQueriesResult {
     queryId: string;
     updateDependenciesIfNeeded?: boolean;
     queryGid: string;
+    deployCredential: boolean;
   }
   
   
@@ -71,7 +72,8 @@ export interface MergedQueriesResult {
           envId: params.envId,
           targetEnvId: params.targetEnvId,
           queryId: params.queryId,
-          updateDependenciesIfNeeded: params.updateDependenciesIfNeeded ?? false
+          updateDependenciesIfNeeded: params.updateDependenciesIfNeeded ?? false,
+          deployCredential: params.deployCredential
         }
       });
       if (response.status === 200) {
diff --git a/client/packages/lowcoder/src/pages/setting/environments/services/workspace.service.ts b/client/packages/lowcoder/src/pages/setting/environments/services/workspace.service.ts
@@ -84,7 +84,6 @@ export async function deployWorkspace(params: {
   envId: string;
   targetEnvId: string;
   workspaceId: string;
-  deployCredential: boolean; // Mandatory parameter
 }): Promise<boolean> {
   try {
     // Use the new endpoint format with only essential parameters
@@ -93,7 +92,6 @@ export async function deployWorkspace(params: {
         orgGid: params.workspaceId, // Using workspaceId as orgGid
         envId: params.envId,
         targetEnvId: params.targetEnvId,
-        deployCredential: params.deployCredential
       }
     });
 
@@ -107,7 +105,6 @@ export async function deployWorkspace(params: {
       );
     }
 
-
     return response.status === 200;
   } catch (error) {
     const errorMessage = error instanceof Error ? error.message : 'Failed to deploy workspace';
