Skip to content

Commit 827958b

Browse files
added showDataLoadingIndicator property in UICompBuilder
1 parent 7553286 commit 827958b

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

client/packages/lowcoder/src/comps/generators/uiCompBuilder.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ import { useMergeCompStyles } from "@lowcoder-ee/util/hooks";
3838
export type NewChildren<ChildrenCompMap extends Record<string, Comp<unknown>>> =
3939
ChildrenCompMap & {
4040
hidden: InstanceType<typeof BoolCodeControl>;
41+
showDataLoadingIndicators: InstanceType<typeof BoolControl>,
4142
className: InstanceType<typeof StringControl>;
4243
dataTestId: InstanceType<typeof StringControl>;
4344
preventStyleOverwriting: InstanceType<typeof BoolControl>;
@@ -78,7 +79,7 @@ export const ExtendedPropertyView = React.memo(<
7879
const editorState = useContext(EditorContext);
7980
const selectedComp = values(editorState?.selectedComps())[0];
8081
const compType = selectedComp?.children?.compType?.getView() as UICompType;
81-
82+
8283
useEffect(() => {
8384
setCompName(uiCompRegistry[compType]?.compName || '');
8485
}, [compType]);
@@ -139,6 +140,7 @@ export function uiChildren<
139140
return {
140141
...childrenMap,
141142
hidden: BoolCodeControl,
143+
showDataLoadingIndicators: withDefault(BoolControl, false),
142144
className: StringControl,
143145
dataTestId: StringControl,
144146
preventStyleOverwriting: withDefault(BoolControl, false),

client/packages/lowcoder/src/comps/utils/propertyUtils.tsx

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,11 @@ export function isCompWithPropertyView<C extends Comp<any> = Comp<any>>(
1616
return "propertyView" in comp && typeof (comp as any)["propertyView"] === "function";
1717
}
1818

19+
export const showDataLoadingIndicatorsPropertyView = (
20+
children: {showDataLoadingIndicators: InstanceType<typeof BoolControl> }
21+
) =>
22+
children.showDataLoadingIndicators.propertyView({ label: trans("themeDetail.showDataLoadingIndicators") });
23+
1924
export const hiddenPropertyView = (children: { hidden: InstanceType<typeof BoolCodeControl> }) =>
2025
children.hidden.propertyView({ label: trans("prop.hide") });
2126

client/packages/lowcoder/src/i18n/locales/en.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2706,7 +2706,8 @@ export const en = {
27062706
"gridColumnsDesc": "Default number of columns typically used for most containers",
27072707
"loadingIndicators": "Loading Indicators",
27082708
"showComponentLoadingIndicators": "Show loading indicators when component load",
2709-
"showDataLoadingIndicators": "Show loading indicators when data load",
2709+
"showDataLoadingIndicators": "Show indicators during data loading",
2710+
"dataLoadingIndicator": "Data loading indicator",
27102711
"background": "Background Styles",
27112712
"gridSettings": "Grid Settings",
27122713
"gridRowHeight": "Grid Row Height",

0 commit comments

Comments
 (0)