remove legacy columns from Deployitemslist

iamfaran · iamfaran · commit 860f5bfbeef4 · 2025-04-17T22:53:04.000+05:00
diff --git a/client/packages/lowcoder/src/pages/setting/environments/components/DeployableItemsList.tsx b/client/packages/lowcoder/src/pages/setting/environments/components/DeployableItemsList.tsx
@@ -31,15 +31,6 @@ function DeployableItemsList<T extends DeployableItem, S extends BaseStats>({
 
   const { openDeployModal } = useDeployModal();
 
-  // Open audit page 
-  const openAuditPage = (item: T, e: React.MouseEvent) => {
-    e.stopPropagation();
-    if (config.audit?.getAuditUrl) {
-      const auditUrl = config.audit.getAuditUrl(item, environment, additionalParams);
-      window.open(auditUrl, '_blank');
-    }
-  };
-
   // Handle row click for navigation
   const handleRowClick = (item: T) => {
     // Skip navigation if the route is just '#' (for non-navigable items)
@@ -56,92 +47,14 @@ function DeployableItemsList<T extends DeployableItem, S extends BaseStats>({
   };
 
   // Determine columns - Use new getColumns method if available, fall back to old approach
-  const columns = config.getColumns ? 
-    config.getColumns({
+  const columns = config.getColumns({
       environment,
       refreshing,
       onToggleManaged,
       openDeployModal,
       additionalParams 
-    }) :
-    generateLegacyColumns();
+    }) 
     
-  // Legacy column generation for backward compatibility
-  function generateLegacyColumns() {
-    let legacyColumns = [...config.columns];
-    
-    // Add managed column if enabled
-    if (config.enableManaged) {
-      legacyColumns.push({
-        title: 'Managed',
-        key: 'managed',
-        render: (_, record: T) => (
-          <Space>
-            <Tag color={record.managed ? 'green' : 'default'}>
-              {record.managed ? 'Managed' : 'Unmanaged'}
-            </Tag>
-            {onToggleManaged && (
-              <Switch
-                size="small"
-                checked={!!record.managed}
-                loading={refreshing}
-                onClick={(checked, e) => {
-                  e.stopPropagation(); // Stop row click event
-                  onToggleManaged(record, checked);
-                }}
-                onChange={() => {}}
-              />
-            )}
-          </Space>
-        ),
-      });
-    }
-
-    // Add deploy action column if enabled
-    if (config.deploy?.enabled) {
-      legacyColumns.push({
-        title: 'Actions',
-        key: 'actions',
-        render: (_, record: T) => (
-          <Space>
-            <Tooltip title={`Deploy this ${config.singularLabel.toLowerCase()} to another environment`}>
-              <Button
-                icon={<CloudUploadOutlined />}
-                onClick={(e) => {
-                  e.stopPropagation(); // Prevent row click navigation
-                  openDeployModal(record, config, environment);
-                }}
-                type="primary"
-                ghost
-              >
-                Deploy
-              </Button>
-            </Tooltip>
-          </Space>
-        ),
-      });
-    }
-
-    // Add audit column if enabled
-    if (config.audit?.enabled) {
-      legacyColumns.push({
-        title: 'Audit',
-        key: 'audit',
-        render: (_, record: T) => (
-          <Tooltip title={config.audit?.tooltip || `View audit logs`}>
-            <Button
-              icon={config.audit?.icon}
-              onClick={(e) => openAuditPage(record, e)}
-            >
-              {config.audit?.label || 'Audit'}
-            </Button>
-          </Tooltip>
-        ),
-      });
-    }
-    
-    return legacyColumns;
-  }
 
   if (loading) {
     return (
diff --git a/client/packages/lowcoder/src/pages/setting/environments/types/deployable-item.types.ts b/client/packages/lowcoder/src/pages/setting/environments/types/deployable-item.types.ts
@@ -76,7 +76,7 @@ export interface DeployableItemConfig<T extends DeployableItem, S extends BaseSt
   columns: ColumnType<T>[];
   
   // New method to generate columns
-  getColumns?: (params: {
+  getColumns: (params: {
     environment: Environment;
     refreshing: boolean;
     onToggleManaged?: (item: T, checked: boolean) => Promise<boolean>;
