fix: avoid editor popup close when open from config popup

raheeliftikhar5 · raheeliftikhar5 · commit b1e50c48f407 · 2023-12-08T11:35:22.000+05:00
diff --git a/client/packages/lowcoder/src/app.tsx b/client/packages/lowcoder/src/app.tsx
@@ -159,7 +159,6 @@ class AppIndex extends React.Component<AppIndexProps, any> {
             )}
           </Switch>
         </Router>
-        <CodeEditorTooltipContainer />
       </Wrapper>
     );
   }
diff --git a/client/packages/lowcoder/src/base/codeEditor/codeEditor.tsx b/client/packages/lowcoder/src/base/codeEditor/codeEditor.tsx
@@ -227,6 +227,7 @@ function useCodeMirror(
     ...props,
     showLineNum,
     onChange: handleChange,
+    tooltipContainer: container.current,
   });
   useEffect(() => reconfigure(viewRef.current), [reconfigure]);
   useEffect(() => {
@@ -385,24 +386,26 @@ export function CodeEditor(props: CodeEditorProps) {
   const { expandable = true, ...editorProps } = props;
   const [disabled, setDisabled] = useState(false);
   return (
-    <CodeEditorCommon {...editorProps} editor={editor} disabled={disabled}>
-      <Container
-        styleName={props.styleName}
-        bordered={props.bordered}
-        disabled={disabled}
-        error={props.hasError}
-        ref={editor as MutableRefObject<HTMLDivElement>}
-        enableClickCompName={props.enableClickCompName}
-      >
-        {expandable && (
-          <CodeEditorPanel
-            breadcrumb={[props.label ?? ""]}
-            editor={<CodeEditorForPanel {...props} styleName="window" showLineNum />}
-            onVisibleChange={(visible) => setDisabled(visible)}
-          />
-        )}
-      </Container>
-    </CodeEditorCommon>
+    <CodeEditorTooltipContainer>
+      <CodeEditorCommon {...editorProps} editor={editor} disabled={disabled}>
+        <Container
+          styleName={props.styleName}
+          bordered={props.bordered}
+          disabled={disabled}
+          error={props.hasError}
+          ref={editor as MutableRefObject<HTMLDivElement>}
+          enableClickCompName={props.enableClickCompName}
+        >
+          {expandable && (
+            <CodeEditorPanel
+              breadcrumb={[props.label ?? ""]}
+              editor={<CodeEditorForPanel {...props} styleName="window" showLineNum />}
+              onVisibleChange={(visible) => setDisabled(visible)}
+            />
+          )}
+        </Container>
+      </CodeEditorCommon>
+    </CodeEditorTooltipContainer>
   );
 }
 
diff --git a/client/packages/lowcoder/src/pages/editor/codeEditorPanel.tsx b/client/packages/lowcoder/src/pages/editor/codeEditorPanel.tsx
@@ -127,7 +127,9 @@ export const CodeEditorPanel = (props: {
       zIndex={Layers.codeEditorPanel}
       popupStyle={{ opacity: 1, display: visible ? "block" : "none" }}
       maskClosable={true}
+      onPopupVisibleChange={(visible) => setVisible(visible)}
       afterPopupVisibleChange={(visible) => props.onVisibleChange(visible)}
+      getPopupContainer={(node: any) => node.parentNode.parentNode}
       popup={() => (
         <Draggable
           positionOffset={{ x: "-50%", y: "-50%" }}

Original file line number	Diff line number	Diff line change
`@@ -159,7 +159,6 @@ class AppIndex extends React.Component<AppIndexProps, any> {`
`159`	`159`	`)}`
`160`	`160`	`</Switch>`
`161`	`161`	`</Router>`
`162`		`- <CodeEditorTooltipContainer />`
`163`	`162`	`</Wrapper>`
`164`	`163`	`);`
`165`	`164`	`}`