fix compile issue

Thomas · ludomikula · commit e6cb95141278 · 2024-07-03T16:33:01.000+02:00
diff --git a/server/api-service/lowcoder-server/src/test/java/org/lowcoder/api/application/ApplicationApiServiceIntegrationTest.java b/server/api-service/lowcoder-server/src/test/java/org/lowcoder/api/application/ApplicationApiServiceIntegrationTest.java
@@ -18,6 +18,7 @@
 import org.lowcoder.domain.application.model.ApplicationType;
 import org.lowcoder.domain.datasource.model.Datasource;
 import org.lowcoder.domain.permission.model.ResourceRole;
+import org.lowcoder.sdk.constants.FieldName;
 import org.lowcoder.sdk.exception.BizError;
 import org.lowcoder.sdk.exception.BizException;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -68,6 +69,7 @@ public void testCreateApplicationSuccess() {
         //
         Mono<ApplicationView> applicationViewMono = datasourceMono.map(datasource -> new CreateApplicationRequest(
                         "org01",
+                        "",
                         "app05",
                         ApplicationType.APPLICATION.getValue(),
                         Map.of("comp", "table"),
@@ -77,7 +79,10 @@ public void testCreateApplicationSuccess() {
                 .flatMap(createApplicationRequest -> applicationApiService.create(createApplicationRequest));
 
         StepVerifier.create(applicationViewMono)
-                .assertNext(applicationView -> Assertions.assertNotNull(applicationView.getApplicationInfoView().getApplicationId()))
+                .assertNext(applicationView -> {
+                    Assertions.assertNotNull(applicationView.getApplicationInfoView().getApplicationId());
+                    Assertions.assertTrue(FieldName.isGID(applicationView.getApplicationInfoView().getApplicationGid()));
+                })
                 .verifyComplete();
     }
 
@@ -100,6 +105,7 @@ public void testUpdateApplicationFailedDueToLackOfDatasourcePermissions() {
         //
         Mono<ApplicationView> applicationViewMono = datasourceMono.map(datasource -> new CreateApplicationRequest(
                         "org01",
+                        "",
                         "app03",
                         ApplicationType.APPLICATION.getValue(),
                         Map.of("comp", "table"),
diff --git a/server/api-service/lowcoder-server/src/test/java/org/lowcoder/api/application/ApplicationApiServiceTest.java b/server/api-service/lowcoder-server/src/test/java/org/lowcoder/api/application/ApplicationApiServiceTest.java
@@ -124,7 +124,7 @@ public void testDeleteNormalApplicationWithError() {
 
     private Mono<ApplicationView> createApplication(String name, String folderId) {
         CreateApplicationRequest createApplicationRequest =
-                new CreateApplicationRequest("org01", name, ApplicationType.APPLICATION.getValue(),
+                new CreateApplicationRequest("org01", "", name, ApplicationType.APPLICATION.getValue(),
                         Map.of("comp", "table"), Map.of("comp", "list"), folderId);
         return applicationApiService.create(createApplicationRequest);
     }
diff --git a/server/api-service/lowcoder-server/src/test/java/org/lowcoder/api/bundle/BundleApiServiceImplTest.java b/server/api-service/lowcoder-server/src/test/java/org/lowcoder/api/bundle/BundleApiServiceImplTest.java
@@ -53,6 +53,7 @@ public void createBundleTestAdminUser() {
         //When org admin user creates bundle it succeed
         Mono<BundleInfoView> bundleInfoViewMono = bundleApiService.create(new BundleEndpoints.CreateBundleRequest(
                 "org01",
+                "",
                 "name1",
                 "title",
                 "description",
@@ -80,6 +81,7 @@ public void createBundleTestDevUser() {
         //When org dev user creates bundle it succeed
         Mono<BundleInfoView> bundleInfoViewMono1 = bundleApiService.create(new BundleEndpoints.CreateBundleRequest(
                 "org01",
+                "",
                 "name2",
                 "title",
                 "description",
@@ -107,6 +109,7 @@ public void createBundleTestNonDevUser() {
         //When non-dev create bundle throws error
         Mono<BundleInfoView> bundleInfoViewMono2 = bundleApiService.create(new BundleEndpoints.CreateBundleRequest(
                 "org01",
+                "",
                 "name3",
                 "title",
                 "description",
@@ -124,6 +127,7 @@ public void moveAddAppTestAdmin() {
         //Create bundles
         Mono<BundleInfoView> bundleInfoViewMono = bundleApiService.create(new BundleEndpoints.CreateBundleRequest(
                 "org01",
+                "",
                 "name4",
                 "title",
                 "description",
@@ -133,6 +137,7 @@ public void moveAddAppTestAdmin() {
 
         Mono<BundleInfoView> bundleInfoViewMono2 = bundleApiService.create(new BundleEndpoints.CreateBundleRequest(
                 "org01",
+                "",
                 "name5",
                 "title",
                 "description",
@@ -167,6 +172,7 @@ public void moveAddAppTestNonDev() {
         //Create bundles
         Mono<BundleInfoView> bundleInfoViewMono = bundleApiService.create(new BundleEndpoints.CreateBundleRequest(
                 "org01",
+                "",
                 "name4",
                 "title",
                 "description",
@@ -176,6 +182,7 @@ public void moveAddAppTestNonDev() {
 
         Mono<BundleInfoView> bundleInfoViewMono2 = bundleApiService.create(new BundleEndpoints.CreateBundleRequest(
                 "org01",
+                "",
                 "name5",
                 "title",
                 "description",
@@ -203,7 +210,7 @@ public void moveAddAppTestNonDev() {
 
     private Mono<BundleInfoView> createBundle(String name, String folderId) {
         BundleEndpoints.CreateBundleRequest createBundleRequest =
-                new BundleEndpoints.CreateBundleRequest("org01", name, "title", "desc", "category", "image", folderId);
+                new BundleEndpoints.CreateBundleRequest("org01", "" ,name, "title", "desc", "category", "image", folderId);
         return bundleApiService.create(createBundleRequest);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ public void testDeleteNormalApplicationWithError() {`
`124`	`124`
`125`	`125`	`private Mono<ApplicationView> createApplication(String name, String folderId) {`
`126`	`126`	`CreateApplicationRequest createApplicationRequest =`
`127`		`- new CreateApplicationRequest("org01", name, ApplicationType.APPLICATION.getValue(),`
	`127`	`+ new CreateApplicationRequest("org01", "", name, ApplicationType.APPLICATION.getValue(),`
`128`	`128`	`Map.of("comp", "table"), Map.of("comp", "list"), folderId);`
`129`	`129`	`return applicationApiService.create(createApplicationRequest);`
`130`	`130`	`}`