Add index validation to Min Heap and Max Heap (TheAlgorithms#3189)

Jainam1401 · siriak · web-flow · commit 1a9937c7cb98 · 2022-07-13T17:40:21.000Z
Co-authored-by: Andrii Siriak &lt;siryaka@gmail.com&gt;
diff --git a/src/main/java/com/thealgorithms/datastructures/heaps/GenericHeap.java b/src/main/java/com/thealgorithms/datastructures/heaps/GenericHeap.java
diff --git a/src/main/java/com/thealgorithms/datastructures/heaps/MaxHeap.java b/src/main/java/com/thealgorithms/datastructures/heaps/MaxHeap.java
@@ -43,6 +43,10 @@ public HeapElement getElement(int elementIndex) {
 
     // Get the key of the element at a given index
     private double getElementKey(int elementIndex) {
+        if ((elementIndex <= 0) || (elementIndex > maxHeap.size())) {
+            throw new IndexOutOfBoundsException("Index out of heap range");
+        }
+        
         return maxHeap.get(elementIndex - 1).getKey();
     }
 
diff --git a/src/main/java/com/thealgorithms/datastructures/heaps/MinHeap.java b/src/main/java/com/thealgorithms/datastructures/heaps/MinHeap.java
@@ -37,6 +37,10 @@ public HeapElement getElement(int elementIndex) {
 
     // Get the key of the element at a given index
     private double getElementKey(int elementIndex) {
+        if ((elementIndex <= 0) || (elementIndex > minHeap.size())) {
+            throw new IndexOutOfBoundsException("Index out of heap range");
+        }
+        
         return minHeap.get(elementIndex - 1).getKey();
     }
 

Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,10 @@ public HeapElement getElement(int elementIndex) {`
`43`	`43`
`44`	`44`	`// Get the key of the element at a given index`
`45`	`45`	`private double getElementKey(int elementIndex) {`
	`46`	`+ if ((elementIndex <= 0) \|\| (elementIndex > maxHeap.size())) {`
	`47`	`+ throw new IndexOutOfBoundsException("Index out of heap range");`
	`48`	`+ }`
	`49`	`+`
`46`	`50`	`return maxHeap.get(elementIndex - 1).getKey();`
`47`	`51`	`}`
`48`	`52`
Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,10 @@ public HeapElement getElement(int elementIndex) {`
`37`	`37`
`38`	`38`	`// Get the key of the element at a given index`
`39`	`39`	`private double getElementKey(int elementIndex) {`
	`40`	`+ if ((elementIndex <= 0) \|\| (elementIndex > minHeap.size())) {`
	`41`	`+ throw new IndexOutOfBoundsException("Index out of heap range");`
	`42`	`+ }`
	`43`	`+`
`40`	`44`	`return minHeap.get(elementIndex - 1).getKey();`
`41`	`45`	`}`
`42`	`46`