Skip to content

Commit b99e12d

Browse files
navingerdaniel-sanche
authored andcommitted
- changed echo API surface to match Java
1 parent 745ac26 commit b99e12d

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

appengine/standard/endpoints-frameworks-v2/echo/main.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,12 @@
2525

2626
# [START messages]
2727
class EchoRequest(messages.Message):
28-
content = messages.StringField(1)
28+
message = messages.StringField(1)
2929

3030

3131
class EchoResponse(messages.Message):
3232
"""A proto Message that contains a simple string field."""
33-
content = messages.StringField(1)
33+
message = messages.StringField(1)
3434

3535

3636
ECHO_RESOURCE = endpoints.ResourceContainer(
@@ -53,8 +53,8 @@ class EchoApi(remote.Service):
5353
http_method='POST',
5454
name='echo')
5555
def echo(self, request):
56-
output_content = ' '.join([request.content] * request.n)
57-
return EchoResponse(content=output_content)
56+
output_message = ' '.join([request.message] * request.n)
57+
return EchoResponse(message=output_message)
5858
# [END echo_api_method]
5959

6060
@endpoints.method(
@@ -66,8 +66,8 @@ def echo(self, request):
6666
http_method='POST',
6767
name='echo_path_parameter')
6868
def echo_path_parameter(self, request):
69-
output_content = ' '.join([request.content] * request.n)
70-
return EchoResponse(content=output_content)
69+
output_message = ' '.join([request.message] * request.n)
70+
return EchoResponse(message=output_message)
7171

7272
@endpoints.method(
7373
# This method takes a ResourceContainer defined above.
@@ -80,14 +80,14 @@ def echo_path_parameter(self, request):
8080
api_key_required=True)
8181
def echo_api_key(self, request):
8282
key, key_type = request.get_unrecognized_field_info('key')
83-
return EchoResponse(content=key)
83+
return EchoResponse(message=key)
8484

8585
@endpoints.method(
8686
# This method takes an empty request body.
8787
message_types.VoidMessage,
8888
# This method returns an Echo message.
8989
EchoResponse,
90-
path='echo/getUserEmail',
90+
path='echo/email',
9191
http_method='GET',
9292
# Require auth tokens to have the following scopes to access this API.
9393
scopes=[endpoints.EMAIL_SCOPE],
@@ -99,7 +99,7 @@ def get_user_email(self, request):
9999
# raise 401 Unauthorized.
100100
if not user:
101101
raise endpoints.UnauthorizedException
102-
return EchoResponse(content=user.email())
102+
return EchoResponse(message=user.email())
103103
# [END echo_api_class]
104104

105105

appengine/standard/endpoints-frameworks-v2/echo/main_test.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@
2222

2323
def test_echo():
2424
api = main.EchoApi()
25-
request = main.EchoApi.echo.remote.request_type(content='Hello world!')
25+
request = main.EchoApi.echo.remote.request_type(message='Hello world!')
2626
response = api.echo(request)
27-
assert 'Hello world!' == response.content
27+
assert 'Hello world!' == response.message
2828

2929

3030
def test_get_user_email():
@@ -38,4 +38,4 @@ def test_get_user_email():
3838
user_mock.return_value = mock.Mock()
3939
user_mock.return_value.email.return_value = 'user@example.com'
4040
response = api.get_user_email(message_types.VoidMessage())
41-
assert 'user@example.com' == response.content
41+
assert 'user@example.com' == response.message

0 commit comments

Comments
 (0)