repos.delete_version: remove entry from manifest if rock is already missing

hishamhm · hishamhm · commit 08ae98e309c3 · 2021-03-19T13:15:53.000-03:00
If rock_manifest could not be found, the entry in manifest is unusable:
without the list of files from rock_manifest, we can't scan the repository
to remove files. This means the entry in the repo manifest is a leftover from
an incomplete removal. Remove the entry from the repo manifest.
diff --git a/src/luarocks/repos.lua b/src/luarocks/repos.lua
@@ -523,7 +523,14 @@ function repos.delete_version(name, version, deps_mode, quick)
    assert(type(deps_mode) == "string")
 
    local rock_manifest, load_err = manif.load_rock_manifest(name, version)
-   if not rock_manifest then return nil, load_err end
+   if not rock_manifest then
+      if not quick then
+         local writer = require("luarocks.manif.writer")
+         writer.remove_from_manifest(name, version, nil, deps_mode)
+         return nil, "rock_manifest file not found for "..name.." "..version.." - removed entry from the manifest"
+      end
+      return nil, load_err
+   end
 
    local repo = cfg.root_dir
    local renames = {}
