Fix : BUG: NoMethodError: undefined method `score' for nil:NilClass !448

seuros · seuros · commit d2ea68199c8c · 2014-12-30T23:48:11.000Z
diff --git a/app/controllers/protips_controller.rb b/app/controllers/protips_controller.rb
@@ -171,8 +171,7 @@ def create
                     end
 
 
-    @protip      = Protip.new(create_params)
-    @protip.user = current_user
+    @protip      = current_user.protips.build(create_params)
     respond_to do |format|
       if @protip.save
         record_event('created protip')
diff --git a/app/models/protip.rb b/app/models/protip.rb
@@ -607,7 +607,13 @@ def views_score
   end
 
   def comments_score
-    self.comments.collect { |comment| comment.likes_value_cache + comment.author.score }.reduce(:+) || 0
+    self.comments.collect do |comment|
+      if comment.author.present?
+        comment.likes_value_cache + comment.author.score
+      else
+        comment.likes_value_cache
+      end
+    end.reduce(:+) || 0
   end
 
   QUALITY_WEIGHT = 20
diff --git a/spec/routing/achievements_routing_spec.rb b/spec/routing/achievements_routing_spec.rb
@@ -1,7 +1,7 @@
 RSpec.describe AchievementsController, type: :routing do
   describe 'routing' do
 
-    it 'routes to #new' do
+    it 'routes to #award' do
       expect(post('/award')).to route_to(controller: 'achievements', action: 'award')
     end
 
