Do not show 'Edit' and 'Close' issues menu to non-collaborators

atermenji · atermenji · commit 00a943e076e6 · 2013-11-02T14:10:52.000+02:00
Refs pockethub#413
diff --git a/app/src/main/java/com/github/mobile/ui/issue/IssuesViewActivity.java b/app/src/main/java/com/github/mobile/ui/issue/IssuesViewActivity.java
@@ -21,15 +21,19 @@
 import static com.github.mobile.Intents.EXTRA_POSITION;
 import static com.github.mobile.Intents.EXTRA_REPOSITORIES;
 import static com.github.mobile.Intents.EXTRA_REPOSITORY;
+import android.accounts.Account;
 import android.content.Intent;
 import android.os.Bundle;
 
 import com.actionbarsherlock.app.ActionBar;
+import com.actionbarsherlock.view.Menu;
 import com.actionbarsherlock.view.MenuItem;
 import com.github.mobile.Intents.Builder;
 import com.github.mobile.R.id;
 import com.github.mobile.R.layout;
 import com.github.mobile.R.string;
+import com.github.mobile.accounts.AccountUtils;
+import com.github.mobile.accounts.AuthenticatedUserTask;
 import com.github.mobile.core.issue.IssueStore;
 import com.github.mobile.core.issue.IssueUtils;
 import com.github.mobile.core.repo.RefreshRepositoryTask;
@@ -51,6 +55,7 @@
 import org.eclipse.egit.github.core.RepositoryId;
 import org.eclipse.egit.github.core.RepositoryIssue;
 import org.eclipse.egit.github.core.User;
+import org.eclipse.egit.github.core.service.CollaboratorService;
 
 /**
  * Activity to display a collection of issues or pull requests in a pager
@@ -164,8 +169,13 @@ public static Intent createIntent(Collection<? extends Issue> issues,
     @Inject
     private IssueStore store;
 
+    @Inject
+    private CollaboratorService collaboratorService;
+
     private final AtomicReference<User> user = new AtomicReference<User>();
 
+    private boolean isCollaborator;
+
     private IssuesPagerAdapter adapter;
 
     private final UrlLauncher urlLauncher = new UrlLauncher(this);
@@ -218,6 +228,9 @@ protected void onSuccess(Repository fullRepository)
                             fullRepository.getOwner());
                 }
             }.execute();
+
+        isCollaborator = false;
+        checkCollaboratorStatus();
     }
 
     private void updateTitle(final int position) {
@@ -286,6 +299,14 @@ protected FragmentProvider getProvider() {
         return adapter;
     }
 
+    @Override
+    public boolean onPrepareOptionsMenu(Menu menu) {
+        menu.findItem(id.m_edit).setVisible(isCollaborator);
+        menu.findItem(id.m_state).setVisible(isCollaborator);
+
+        return super.onPrepareOptionsMenu(menu);
+    }
+
     @Override
     public boolean onOptionsItemSelected(MenuItem item) {
         switch (item.getItemId()) {
@@ -312,4 +333,23 @@ public boolean onOptionsItemSelected(MenuItem item) {
             return super.onOptionsItemSelected(item);
         }
     }
+
+    private void checkCollaboratorStatus() {
+        new AuthenticatedUserTask<Boolean>(this) {
+
+            @Override
+            protected Boolean run(Account account) throws Exception {
+                return collaboratorService.isCollaborator(
+                    repo, AccountUtils.getLogin(IssuesViewActivity.this));
+            }
+
+            @Override
+            protected void onSuccess(Boolean collaborator) throws Exception {
+                super.onSuccess(collaborator);
+
+                isCollaborator = collaborator;
+                invalidateOptionsMenu();
+            }
+        }.execute();
+    }
 }
