Verify registered authenticator has expected package name

kevinsawicki · kevinsawicki · commit a9f696024d3e · 2012-07-10T11:56:22.000-07:00
This ensures that expected authenticator will be used before an account is requested to be added. Without this check the account manager future will hang if another application has registered an authenticator for the account type id being used. Closes issue pockethub#88
diff --git a/app/src/main/java/com/github/mobile/accounts/AccountUtils.java b/app/src/main/java/com/github/mobile/accounts/AccountUtils.java
@@ -23,6 +23,7 @@
 import android.accounts.AccountManager;
 import android.accounts.AccountManagerFuture;
 import android.accounts.AccountsException;
+import android.accounts.AuthenticatorDescription;
 import android.accounts.AuthenticatorException;
 import android.accounts.OperationCanceledException;
 import android.app.Activity;
@@ -50,11 +51,40 @@ public class AccountUtils {
 
     private static final String TAG = "AccountUtils";
 
+    private static boolean AUTHENTICATOR_CHECKED;
+
+    private static boolean HAS_AUTHENTICATOR;
+
     private static class AuthenticatorConflictException extends IOException {
 
         private static final long serialVersionUID = 641279204734869183L;
     }
 
+    /**
+     * Verify authenticator registered for account type matches the package name
+     * of this application
+     *
+     * @param manager
+     * @return true is authenticator registered, false otherwise
+     */
+    public static boolean hasAuthenticator(final AccountManager manager) {
+        if (!AUTHENTICATOR_CHECKED) {
+            final AuthenticatorDescription[] types = manager
+                    .getAuthenticatorTypes();
+            if (types != null && types.length > 0)
+                for (AuthenticatorDescription descriptor : types)
+                    if (descriptor != null
+                            && ACCOUNT_TYPE.equals(descriptor.type)) {
+                        HAS_AUTHENTICATOR = "com.github.mobile"
+                                .equals(descriptor.packageName);
+                        break;
+                    }
+            AUTHENTICATOR_CHECKED = true;
+        }
+
+        return HAS_AUTHENTICATOR;
+    }
+
     /**
      * Is the given user the owner of the default account?
      *
@@ -146,6 +176,9 @@ public static Account getAccount(final AccountManager manager,
 
         Account[] accounts;
         try {
+            if (!hasAuthenticator(manager))
+                throw new AuthenticatorConflictException();
+
             while ((accounts = getAccounts(manager)).length == 0) {
                 if (loggable)
                     Log.d(TAG, "No GitHub accounts for activity=" + activity);
