Show progress dialog while repository is loading

kevinsawicki · kevinsawicki · commit c546afc59e05 · 2012-07-11T11:58:23.000-07:00
Use RefreshRepositoryTask from SearchRepositoryListFragment
to load the repository in a background task with an
indeterminate progress dialog.

Previously the task would load with no feedback between
when the list item was clicked and when the repository
was loaded and opened in a new activity
diff --git a/app/res/values/strings.xml b/app/res/values/strings.xml
@@ -206,5 +206,6 @@
     <string name="cancel">Cancel</string>
     <string name="authenticator_conflict_title">App Conflict</string>
     <string name="authenticator_conflict_message">Another installed app is already configured for GitHub authentication.\n\nYou must remove the other app from the Accounts &amp; sync settings and uninstall it before the GitHub app can be used.</string>
+    <string name="opening_repository">"Opening {0}…"</string>
 
 </resources>
diff --git a/app/src/main/java/com/github/mobile/core/repo/RefreshRepositoryTask.java b/app/src/main/java/com/github/mobile/core/repo/RefreshRepositoryTask.java
@@ -18,7 +18,7 @@
 import android.content.Context;
 import android.util.Log;
 
-import com.github.mobile.accounts.AuthenticatedUserTask;
+import com.github.mobile.ui.ProgressDialogTask;
 import com.google.inject.Inject;
 
 import org.eclipse.egit.github.core.IRepositoryIdProvider;
@@ -28,7 +28,7 @@
 /**
  * Task to refresh a repository
  */
-public class RefreshRepositoryTask extends AuthenticatedUserTask<Repository> {
+public class RefreshRepositoryTask extends ProgressDialogTask<Repository> {
 
     private static final String TAG = "RefreshRepositoryTask";
 
diff --git a/app/src/main/java/com/github/mobile/ui/repo/SearchRepositoryListFragment.java b/app/src/main/java/com/github/mobile/ui/repo/SearchRepositoryListFragment.java
@@ -22,12 +22,13 @@
 
 import com.github.mobile.R.string;
 import com.github.mobile.ThrowableLoader;
-import com.github.mobile.accounts.AuthenticatedUserTask;
+import com.github.mobile.core.repo.RefreshRepositoryTask;
 import com.github.mobile.ui.ItemListAdapter;
 import com.github.mobile.ui.ItemListFragment;
 import com.github.mobile.ui.ItemView;
 import com.google.inject.Inject;
 
+import java.text.MessageFormat;
 import java.util.List;
 
 import org.eclipse.egit.github.core.Repository;
@@ -65,11 +66,15 @@ public SearchRepositoryListFragment setQuery(final String query) {
     public void onListItemClick(ListView l, View v, int position, long id) {
         final SearchRepository result = (SearchRepository) l
                 .getItemAtPosition(position);
-        new AuthenticatedUserTask<Repository>(getActivity()) {
+        new RefreshRepositoryTask(getActivity(), result) {
 
             @Override
-            public Repository run() throws Exception {
-                return service.getRepository(result);
+            public void execute() {
+                showIndeterminate(MessageFormat.format(
+                        getString(string.opening_repository),
+                        result.generateId()));
+
+                super.execute();
             }
 
             @Override
