Merge pull request coderwall#236 from YaroSpace/bug_delete_user_#398

just3ws · just3ws · commit 23b29a002ca0 · 2014-11-03T13:23:35.000-06:00
Bug delete user #398
diff --git a/app/models/user.rb b/app/models/user.rb
@@ -82,10 +82,12 @@ class User < ActiveRecord::Base
   has_one :github_profile  , class_name: 'Users::Github::Profile', dependent: :destroy
   has_many :github_repositories, through: :github_profile , source: :repositories
 
-
   geocoded_by :location, latitude: :lat, longitude: :lng, country: :country, state_code: :state_name
+  # FIXME: Move to background job
   after_validation :geocode_location, if: :location_changed? unless Rails.env.test?
 
+  before_destroy ->{ protips.destroy_all }, prepend: true
+
   def near
     User.near([lat, lng])
   end
@@ -130,7 +132,6 @@ def self.with_username(username, provider = :username)
     where(["UPPER(#{sql_injection_safe_where_clause}) = UPPER(?)", username]).first
   end
 
-
   # Todo State machine
   def banned?
     banned_at.present?
@@ -923,7 +924,6 @@ def make_referral_token
   end
 
   after_save :refresh_dependencies
-  after_destroy :refresh_protips
 
   def refresh_dependencies
     if username_changed? or avatar_changed? or team_document_id_changed?
diff --git a/spec/features/helpers/general_helpers.rb b/spec/features/helpers/general_helpers.rb
@@ -24,6 +24,8 @@ def login_as(settings = {})
         fill_in 'user_location', with: settings[:location]
         click_button 'Finish'
       end
+
+      user
     end
 
     def create_team(name = 'TEST_TEAM')
diff --git a/spec/features/users/user_management_spec.rb b/spec/features/users/user_management_spec.rb
@@ -0,0 +1,58 @@
+require "rails_helper"
+
+feature "User management", js: true do
+  describe 'deleting a user' do
+    before do
+      stub_request(:post, /api.mixpanel.com/)
+    end
+
+    let!(:user) { login_as(username: 'alice', bypass_ui_login: true) }
+
+    scenario 'user is presented with confirmation dialog when deletes his account' do
+      visit '/settings'
+      find('.delete').click_link 'click here.'
+
+      expect(page).to have_content 'Warning: clicking this link below will permenatly delete your Coderwall account and its data.'
+      expect(page).to have_button 'Delete your account & sign out'
+    end
+
+    scenario 'user is redirected to /welcome after deleting hios account' do
+      visit '/settings'
+      find('.delete').click_link 'click here.'
+      find('.save').click_button 'Delete your account & sign out'
+
+      expect(current_path).to eq('/welcome')
+    end
+
+    scenario 'user cannot login after deleting his account' do
+      visit '/settings'
+      find('.delete').click_link 'click here.'
+      find('.save').click_button 'Delete your account & sign out'
+
+      visit "/auth/developer"
+      fill_in 'name', with: user.username
+      fill_in 'email', with: user.email
+      click_button 'Sign In'
+
+      expect(current_path).to eq(new_user_path)
+    end
+
+    scenario 'users protips are not displayed after he deletes his account' do
+      Protip.rebuild_index
+      protip_1, protip_2 = Fabricate.times(2, :protip, user: user)
+      protip_3 = Fabricate(:protip)
+
+      visit '/settings'
+      find('.delete').click_link 'click here.'
+      find('.save').click_button 'Delete your account & sign out'
+
+      login_as(username: 'bob', bypass_ui_login: true)
+      visit '/p/fresh'
+
+      expect(page).not_to have_content(protip_1.title)
+      expect(page).not_to have_content(protip_2.title)
+      expect(page).to have_content(protip_3.title)
+    end
+  end
+
+end
diff --git a/spec/models/user_spec.rb b/spec/models/user_spec.rb
@@ -329,7 +329,16 @@ class AlsoNotaBadge < BadgeBase
     it "should not default to banned" do
       expect(user.banned?).to eq(false)
     end
+ end
 
+  describe 'deleting a user', focus: true do
+    it 'deletes asosciated prtotips' do
+      user = Fabricate(:user)
+      protip = Fabricate(:protip, user: user)
+
+      expect(user.reload.protips).to receive(:destroy_all).and_return(false)
+      user.destroy
+    end
   end
 
 end
diff --git a/spec/requests/users_spec.rb b/spec/requests/users_spec.rb
@@ -0,0 +1,20 @@
+RSpec.describe "User management", :type => :request do
+
+  describe 'deleting a user' do
+    it 'deletes associated protips and reindex search index' do
+      user = Fabricate(:user)
+
+      Protip.rebuild_index
+      protip_1, protip_2 = Fabricate.times(2, :protip, user: user)
+      protip_3 = Fabricate(:protip)
+
+      user.reload.destroy
+      search = Protip.search('*').map(&:title)
+
+      expect(search).not_to include(protip_1.title)
+      expect(search).not_to include(protip_2.title)
+      expect(search).to include(protip_3.title)
+    end
+  end
+
+end
