Skip to content

Commit da0d097

Browse files
authored
Make TODO clearer what action to take. (GoogleCloudPlatform#1963)
* Make TODO clearer what action to take. Describe the variables to set explicitly (rather than "this"), as suggested in internal CL 227863277. * Use standard 'uncomment the variable below' for TODO * Move variable below TODO.
1 parent 8e36ed7 commit da0d097

File tree

1 file changed

+12
-7
lines changed

1 file changed

+12
-7
lines changed

bigquery/cloud-client/user_credentials.py

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,13 @@ def main(project, launch_browser=True):
2727
# [START bigquery_auth_user_flow]
2828
from google_auth_oauthlib import flow
2929

30-
# TODO: Use a local server in the auth flow? This is recommended but does
31-
# not work if accessing the application remotely, such as over SSH or
32-
# from a remote Jupyter notebook.
30+
# TODO: Uncomment the line below to set the `launch_browser` variable.
3331
# launch_browser = True
32+
#
33+
# The `launch_browser` boolean variable indicates if a local server in the
34+
# auth flow. A value of `True` is recommended, but a local server does not
35+
# work if accessing the application remotely, such as over SSH or from a
36+
# remote Jupyter notebook.
3437

3538
appflow = flow.InstalledAppFlow.from_client_secrets_file(
3639
'client_secrets.json',
@@ -47,11 +50,13 @@ def main(project, launch_browser=True):
4750
# [START bigquery_auth_user_query]
4851
from google.cloud import bigquery
4952

50-
# TODO: This project will be billed for the query processing. The user must
51-
# have the bigquery.jobs.create permission on this project to run a
52-
# query. See:
53-
# https://cloud.google.com/bigquery/docs/access-control#permissions
53+
# TODO: Uncomment the line below to set the `project` variable.
5454
# project = 'user-project-id'
55+
#
56+
# The `project` variable defines the project to be billed for query
57+
# processing. The user must have the bigquery.jobs.create permission on
58+
# this project to run a query. See:
59+
# https://cloud.google.com/bigquery/docs/access-control#permissions
5560

5661
client = bigquery.Client(project=project, credentials=credentials)
5762

0 commit comments

Comments
 (0)