Skip to content

Commit 6a5fb1f

Browse files
committed
pkg-config: Sort the different sections
Because of the fact that pkg-config is pants-on-head retarded and that the Linux linker *requires* a static library to come before all its dynamic dependencies in the link path, calling `pkg-config --libs --static` was generating the wrong flags for linking. Before this patch: -Wl,-Bsymbolic-functions -Wl,-z,relro -L/usr/local/lib -lcurl -lssh2 -lrt -lgit2 -lssl -lcrypto -ldl -lz After this patch: -Wl,-Bsymbolic-functions -Wl,-z,relro -L/usr/local/lib -lgit2 -lcurl -lssh2 -lrt -lssl -lcrypto -ldl -lz By setting the "Libs" line before all other rules, we make sure that `-lgit2` is the first library in the link path and that it gets its symbols resolved with the libraries coming after it. This fix (ab)uses an implementation detail in `pkg-config` (namely, that flags are output as they are found on the file), but this detail seems to be stable between releases and always gives a stable output.
1 parent 84d5a98 commit 6a5fb1f

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

libgit2.pc.in

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,9 @@ includedir=@CMAKE_INSTALL_PREFIX@/@INCLUDE_INSTALL_DIR@
44
Name: libgit2
55
Description: The git library, take 2
66
Version: @LIBGIT2_VERSION_STRING@
7-
Requires.private: @LIBGIT2_PC_REQUIRES@
8-
Libs.private: @LIBGIT2_PC_LIBS@
7+
98
Libs: -L${libdir} -lgit2
9+
Libs.private: @LIBGIT2_PC_LIBS@
10+
Requires.private: @LIBGIT2_PC_REQUIRES@
11+
1012
Cflags: -I${includedir}

0 commit comments

Comments
 (0)