From d1c931c30fbd4c57bfdebf243a8dcff6b9e533fd Mon Sep 17 00:00:00 2001 From: stonebig Date: Sat, 16 Nov 2019 15:08:42 +0100 Subject: [PATCH 1/3] no attribute '_send_event' problem in a blind way at least now, there is no more https://github.com/matplotlib/jupyter-matplotlib/issues/115: - I have my figures, - It didn't remove last "improvement" --- ipympl/backend_nbagg.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ipympl/backend_nbagg.py b/ipympl/backend_nbagg.py index 94a07899..f9103f93 100644 --- a/ipympl/backend_nbagg.py +++ b/ipympl/backend_nbagg.py @@ -210,7 +210,10 @@ def show(self): self.canvas.draw_idle() def destroy(self): - self.canvas.close() + try: + self.canvas.close() #stonebig self.canvas.close() + except: #stonebig self.canvas.close() + self._send_event('close') def new_figure_manager(num, *args, **kwargs): From 6da0818c4164e620ff6c2205346b929dfb088f0f Mon Sep 17 00:00:00 2001 From: stonebig Date: Sat, 16 Nov 2019 15:09:43 +0100 Subject: [PATCH 2/3] Update backend_nbagg.py --- ipympl/backend_nbagg.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ipympl/backend_nbagg.py b/ipympl/backend_nbagg.py index f9103f93..e8a79434 100644 --- a/ipympl/backend_nbagg.py +++ b/ipympl/backend_nbagg.py @@ -211,8 +211,8 @@ def show(self): def destroy(self): try: - self.canvas.close() #stonebig self.canvas.close() - except: #stonebig self.canvas.close() + self.canvas.close() + except: self._send_event('close') From 06c21d609b9583695afd17dcbd7795823d28fc46 Mon Sep 17 00:00:00 2001 From: stonebig Date: Sat, 16 Nov 2019 15:28:54 +0100 Subject: [PATCH 3/3] Update backend_nbagg.py --- ipympl/backend_nbagg.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipympl/backend_nbagg.py b/ipympl/backend_nbagg.py index e8a79434..054d73a6 100644 --- a/ipympl/backend_nbagg.py +++ b/ipympl/backend_nbagg.py @@ -212,7 +212,7 @@ def show(self): def destroy(self): try: self.canvas.close() - except: + except AttributeError: self._send_event('close')