Skip to content

Commit 00d1f25

Browse files
oscargusQuLogic
authored andcommitted
Backport PR #27059: ci: Clean up Python 3.12 builds
1 parent 7b07419 commit 00d1f25

File tree

2 files changed

+6
-24
lines changed

2 files changed

+6
-24
lines changed

.github/workflows/cibuildwheel.yml

-14
Original file line numberDiff line numberDiff line change
@@ -145,20 +145,6 @@ jobs:
145145
env:
146146
CIBW_BUILD: "cp312-*"
147147
CIBW_ARCHS: ${{ matrix.cibw_archs }}
148-
# Remove this once NumPy with Python 3.12 wheels is not pre-release.
149-
CIBW_BEFORE_BUILD: >-
150-
pip install certifi "pybind11>=2.6" "setuptools>=42" "setuptools_scm>=7" &&
151-
pip install --pre "numpy>=1.25" &&
152-
rm -rf {package}/build
153-
CIBW_BEFORE_BUILD_WINDOWS: >-
154-
pip install certifi delvewheel "pybind11>=2.6" "setuptools>=42" "setuptools_scm>=7" &&
155-
pip install --pre "numpy>=1.25" &&
156-
rm -rf {package}/build
157-
CIBW_ENVIRONMENT: PIP_NO_BUILD_ISOLATION=0
158-
# Remove this once contourpy has Python 3.12 wheels.
159-
CIBW_BEFORE_TEST: >-
160-
pip install "meson>=1.2.0" "meson-python>=0.13.1" "ninja" "pybind11>=2.10.4" &&
161-
pip install --pre "numpy>=1.25"
162148

163149
- name: Build wheels for CPython 3.11
164150
uses: pypa/cibuildwheel@fff9ec32ed25a9c576750c91e06b410ed0c15db7 # v2.16.2

.github/workflows/tests.yml

+6-10
Original file line numberDiff line numberDiff line change
@@ -78,10 +78,8 @@ jobs:
7878
pyside6-ver: '!=6.5.1'
7979
extra-requirements: '-r requirements/testing/extra.txt'
8080
- os: ubuntu-22.04
81-
python-version: '3.12-dev'
81+
python-version: '3.12'
8282
pyside6-ver: '!=6.5.1'
83-
pre: true
84-
no-build-isolation: true
8583
- os: macos-latest
8684
python-version: 3.9
8785
# https://bugreports.qt.io/projects/PYSIDE/issues/PYSIDE-2346
@@ -196,10 +194,8 @@ jobs:
196194
python -m pip install --upgrade pip setuptools wheel
197195
198196
# Install pre-release versions during our weekly upcoming dependency tests.
199-
# Also install for 3.12 to get working NumPy (remove when 1.26 is released)
200-
if [[ "${{ github.event_name == 'schedule' &&
201-
matrix.name-suffix != '(Minimum Versions)' }}" = "true"
202-
|| "${{ matrix.pre }}" = "true" ]]; then
197+
if [[ "${{ github.event_name }}" == 'schedule'
198+
&& "${{ matrix.name-suffix }}" != '(Minimum Versions)' ]]; then
203199
PRE="--pre"
204200
fi
205201
@@ -244,7 +240,7 @@ jobs:
244240
echo 'PyQt5 is available' ||
245241
echo 'PyQt5 is not available'
246242
if [[ "${{ runner.os }}" != 'macOS'
247-
&& "${{ matrix.python-version != '3.12-dev'}}" = "true" ]]; then
243+
&& "${{ matrix.python-version }}" != '3.12' ]]; then
248244
python -mpip install --upgrade pyside2${{ matrix.pyside2-ver }} &&
249245
python -c 'import PySide2.QtCore' &&
250246
echo 'PySide2 is available' ||
@@ -257,14 +253,14 @@ jobs:
257253
echo 'PyQt6 is not available'
258254
fi
259255
if [[ "${{ runner.os }}" != 'macOS'
260-
&& "${{ matrix.python-version != '3.12-dev'}}" = "true" ]]; then
256+
&& "${{ matrix.python-version }}" != '3.12' ]]; then
261257
python -mpip install --upgrade pyside6${{ matrix.pyside6-ver }} &&
262258
python -c 'import PySide6.QtCore' &&
263259
echo 'PySide6 is available' ||
264260
echo 'PySide6 is not available'
265261
fi
266262
267-
if [[ "${{ matrix.python-version != '3.12-dev'}}" = "true" ]]; then
263+
if [[ "${{ matrix.python-version }}" != '3.12' ]]; then
268264
python -mpip install --upgrade \
269265
-f "https://extras.wxpython.org/wxPython4/extras/linux/gtk3/${{ matrix.os }}" \
270266
wxPython &&

0 commit comments

Comments
 (0)