Fix deprecation of withdash for figtext().

anntzer · anntzer · commit 154082d9bd87 · 2019-05-07T11:40:57.000+02:00
Apply the same check for _deprecated_parameter in Figure.text() (aka
plt.figtext()) as in Axes.text().

Otherwise any call to Figure.text(), even without passing withdash,
emits a deprecation warning (because _deprecated_parameter is truthy).
diff --git a/lib/matplotlib/figure.py b/lib/matplotlib/figure.py
@@ -1867,7 +1867,8 @@ def text(self, x, y, s, fontdict=None, withdash=False, **kwargs):
         """
         default = dict(transform=self.transFigure)
 
-        if withdash:
+        if (withdash
+                and withdash is not cbook.deprecation._deprecated_parameter):
             text = TextWithDash(x=x, y=y, text=s)
         else:
             text = Text(x=x, y=y, text=s)
