Set the app icon in the MacOsX manager

joelfrederico · joelfrederico · commit 170457364697 · 2021-11-28T20:07:16.000-05:00
diff --git a/lib/matplotlib/backends/backend_macosx.py b/lib/matplotlib/backends/backend_macosx.py
@@ -66,7 +66,10 @@ class FigureManagerMac(_macosx.FigureManager, FigureManagerBase):
     Wrap everything up into a window for the pylab interface
     """
     def __init__(self, canvas, num):
-        _macosx.FigureManager.__init__(self, canvas)
+        icon_path = None
+        if 'com.adobe.pdf' in _macosx.FigureManager._get_image_types():
+            icon_path = str(cbook._get_data_path('images/matplotlib.pdf'))
+        _macosx.FigureManager.__init__(self, canvas, icon_path)
         FigureManagerBase.__init__(self, canvas, num)
         if mpl.rcParams['toolbar'] == 'toolbar2':
             self.toolbar = NavigationToolbar2Mac(canvas)
diff --git a/src/_macosx.m b/src/_macosx.m
@@ -1,3 +1,4 @@
+#include <objc/NSObjCRuntime.h>
 #define PY_SSIZE_T_CLEAN
 #include <Cocoa/Cocoa.h>
 #include <ApplicationServices/ApplicationServices.h>
@@ -629,6 +630,39 @@ static CGFloat _get_device_scale(CGContextRef cr)
     return (PyObject*)self;
 }
 
+int set_icon(PyObject* icon_path) {
+    if (!icon_path) {
+        return 0;
+    }
+    const char* icon_path_ptr = PyUnicode_AsUTF8(icon_path);
+    if (!icon_path_ptr) {
+        Py_DECREF(icon_path);
+        return -1;
+    }
+    NSString* ns_icon_path = [NSString stringWithUTF8String: icon_path_ptr];
+    if (!ns_icon_path) {
+        Py_DECREF(icon_path);
+        PyErr_SetString(PyExc_RuntimeError, "Could not convert to NSString*");
+        return -1;
+    }
+    NSImage* image = [[NSImage alloc] initByReferencingFile: ns_icon_path];
+    [ns_icon_path release];
+    if (!image) {
+        PyErr_SetString(PyExc_RuntimeError, "Could not create NSImage*");
+        [image release];
+        return -1;
+    }
+    if (!image.valid) {
+        PyErr_SetString(PyExc_RuntimeError, "Image is not valid");
+        [image release];
+        return -1;
+    }
+    NSApplication* app = [NSApplication sharedApplication];
+    app.applicationIconImage = image;
+    [image release];
+    return 0;
+}
+
 static int
 FigureManager_init(FigureManager *self, PyObject *args, PyObject *kwds)
 {
@@ -637,24 +671,32 @@ static CGFloat _get_device_scale(CGContextRef cr)
     View* view;
     PyObject* size;
     int width, height;
-    PyObject* obj;
     FigureCanvas* canvas;
+    PyObject* icon_path;
 
     if (!self->window) {
         PyErr_SetString(PyExc_RuntimeError, "NSWindow* is NULL");
         return -1;
     }
+    static char* kwlist[3] = { "canvas", "icon_path", NULL };
+    icon_path = NULL;
+    if (!PyArg_ParseTupleAndKeywords(args, kwds,
+                "O!|O&", kwlist,
+                &FigureCanvasType, &canvas,
+                &PyUnicode_FSDecoder, &icon_path)) {
+        return -1;
+    }
+    if (set_icon(icon_path)) {
+        return -1;
+    }
 
-    if (!PyArg_ParseTuple(args, "O", &obj)) { return -1; }
-
-    canvas = (FigureCanvas*)obj;
     view = canvas->view;
     if (!view) { /* Something really weird going on */
         PyErr_SetString(PyExc_RuntimeError, "NSView* is NULL");
         return -1;
     }
 
-    size = PyObject_CallMethod(obj, "get_width_height", "");
+    size = PyObject_CallMethod((PyObject*)canvas, "get_width_height", "");
     if (!size) { return -1; }
     if (!PyArg_ParseTuple(size, "ii", &width, &height)) {
         Py_DECREF(size);
@@ -778,6 +820,23 @@ static CGFloat _get_device_scale(CGContextRef cr)
     Py_RETURN_NONE;
 }
 
+static PyObject*
+FigureManager__get_image_types(PyObject* no_self, PyObject* no_args)
+{
+    NSArray<NSString*>* images = NSImage.imageUnfilteredTypes;
+    const NSUInteger n_images = [images count];
+    PyObject* out = PyList_New(n_images);
+    if (!out) {
+        [images release];
+        return NULL;
+    }
+    for (NSUInteger i=0; i < n_images; ++i) {
+        const char* string = images[i].UTF8String;
+        PyList_SET_ITEM(out, i, PyUnicode_FromString(string));
+    }
+    return out;
+}
+
 static PyMethodDef FigureManager_methods[] = {
     {"show",
      (PyCFunction)FigureManager_show,
@@ -804,6 +863,11 @@ static CGFloat _get_device_scale(CGContextRef cr)
      METH_VARARGS,
      NULL,  // docstring inherited.
     },
+    {"_get_image_types",
+     FigureManager__get_image_types,
+     METH_STATIC | METH_NOARGS,
+     "Return image types supported by macOS"
+    },
     {NULL}  /* Sentinel */
 };
 
