Skip to content

Commit 19f0d79

Browse files
guru2605meeseeksmachine
authored andcommitted
Backport PR #27093: [Doc]: Move Automated Tests section to workflow docs #26998
1 parent f115ee0 commit 19f0d79

File tree

2 files changed

+55
-49
lines changed

2 files changed

+55
-49
lines changed

doc/devel/coding_guide.rst

+1-49
Original file line numberDiff line numberDiff line change
@@ -339,55 +339,7 @@ Merging
339339

340340
Automated tests
341341
---------------
342-
343-
Whenever a pull request is created or updated, various automated test tools
344-
will run on all supported platforms and versions of Python.
345-
346-
* Make sure the Linting, GitHub Actions, AppVeyor, CircleCI, and Azure
347-
pipelines are passing before merging (All checks are listed at the bottom of
348-
the GitHub page of your pull request). Here are some tips for finding the
349-
cause of the test failure:
350-
351-
- If *Linting* fails, you have a code style issue, which will be listed
352-
as annotations on the pull request's diff.
353-
- If *Mypy* or *Stubtest* fails, you have inconsistency in type hints, which
354-
will be listed as annotations in the diff.
355-
- If a GitHub Actions or AppVeyor run fails, search the log for ``FAILURES``.
356-
The subsequent section will contain information on the failed tests.
357-
- If CircleCI fails, likely you have some reStructuredText style issue in
358-
the docs. Search the CircleCI log for ``WARNING``.
359-
- If Azure pipelines fail with an image comparison error, you can find the
360-
images as *artifacts* of the Azure job:
361-
362-
- Click *Details* on the check on the GitHub PR page.
363-
- Click *View more details on Azure Pipelines* to go to Azure.
364-
- On the overview page *artifacts* are listed in the section *Related*.
365-
366-
367-
* Codecov and CodeQL are currently for information only. Their failure is not
368-
necessarily a blocker.
369-
370-
* tox_ is not used in the automated testing. It is supported for testing
371-
locally.
372-
373-
.. _tox: https://tox.readthedocs.io/
374-
375-
* If you know only a subset of CIs need to be run, this can be controlled on
376-
individual commits by including the following substrings in commit messages:
377-
378-
- ``[ci doc]``: restrict the CI to documentation checks. For when you only
379-
changed documentation (this skip is automatic if the changes are only under
380-
``doc/`` or ``galleries/``).
381-
- ``[skip circle]``: skip the documentation build check. For when you didn't
382-
change documentation.
383-
- Unit tests can be turned off for individual platforms with
384-
385-
- ``[skip actions]``: GitHub Actions
386-
- ``[skip appveyor]`` (must be in the first line of the commit): AppVeyor
387-
- ``[skip azp]``: Azure Pipelines
388-
389-
- ``[skip ci]``: skip all CIs. Use this only if you know your changes do not
390-
need to be tested at all, which is very rare.
342+
Before being merged, a PR should pass the :ref:`automated-tests`. If you are unsure why a test is failing, ask on the PR or in our `chat space <https://gitter.im/matplotlib/matplotlib>`_
391343

392344
.. _pr-squashing:
393345

doc/devel/development_workflow.rst

+54
Original file line numberDiff line numberDiff line change
@@ -426,3 +426,57 @@ thought it was.
426426
Be judicious with force-pushing. It is effectively re-writing published
427427
history, and if anyone has fetched the old commits, it will have a different view
428428
of history which can cause confusion.
429+
430+
.. _automated-tests:
431+
432+
Automated tests
433+
---------------
434+
435+
Whenever a pull request is created or updated, various automated test tools
436+
will run on all supported platforms and versions of Python.
437+
438+
* Make sure the Linting, GitHub Actions, AppVeyor, CircleCI, and Azure
439+
pipelines are passing before merging (All checks are listed at the bottom of
440+
the GitHub page of your pull request). Here are some tips for finding the
441+
cause of the test failure:
442+
443+
- If *Linting* fails, you have a code style issue, which will be listed
444+
as annotations on the pull request's diff.
445+
- If *Mypy* or *Stubtest* fails, you have inconsistency in type hints, which
446+
will be listed as annotations in the diff.
447+
- If a GitHub Actions or AppVeyor run fails, search the log for ``FAILURES``.
448+
The subsequent section will contain information on the failed tests.
449+
- If CircleCI fails, likely you have some reStructuredText style issue in
450+
the docs. Search the CircleCI log for ``WARNING``.
451+
- If Azure pipelines fail with an image comparison error, you can find the
452+
images as *artifacts* of the Azure job:
453+
454+
- Click *Details* on the check on the GitHub PR page.
455+
- Click *View more details on Azure Pipelines* to go to Azure.
456+
- On the overview page *artifacts* are listed in the section *Related*.
457+
458+
459+
* Codecov and CodeQL are currently for information only. Their failure is not
460+
necessarily a blocker.
461+
462+
* tox_ is not used in the automated testing. It is supported for testing
463+
locally.
464+
465+
.. _tox: https://tox.readthedocs.io/
466+
467+
* If you know only a subset of CIs need to be run, this can be controlled on
468+
individual commits by including the following substrings in commit messages:
469+
470+
- ``[ci doc]``: restrict the CI to documentation checks. For when you only
471+
changed documentation (this skip is automatic if the changes are only under
472+
``doc/`` or ``galleries/``).
473+
- ``[skip circle]``: skip the documentation build check. For when you didn't
474+
change documentation.
475+
- Unit tests can be turned off for individual platforms with
476+
477+
- ``[skip actions]``: GitHub Actions
478+
- ``[skip appveyor]`` (must be in the first line of the commit): AppVeyor
479+
- ``[skip azp]``: Azure Pipelines
480+
481+
- ``[skip ci]``: skip all CIs. Use this only if you know your changes do not
482+
need to be tested at all, which is very rare.

0 commit comments

Comments
 (0)