Merge pull request #19180 from timhoffm/fix-artist-remove-callback

anntzer · web-flow · commit 1c03163b5513 · 2020-12-29T18:30:59.000+01:00
Fix Artist.remove_callback()
diff --git a/lib/matplotlib/artist.py b/lib/matplotlib/artist.py
@@ -351,7 +351,7 @@ def remove_callback(self, oid):
         --------
         add_callback
         """
-        self._callbacks.disconnect("pchanged", oid)
+        self._callbacks.disconnect(oid)
 
     def pchanged(self):
         """
diff --git a/lib/matplotlib/tests/test_artist.py b/lib/matplotlib/tests/test_artist.py
@@ -303,3 +303,21 @@ def test_set_alpha_for_array():
         art._set_alpha_for_array([0.5, 1.1])
     with pytest.raises(ValueError, match="alpha must be between 0 and 1"):
         art._set_alpha_for_array([0.5, np.nan])
+
+
+def test_callbacks():
+    def func(artist):
+        func.counter += 1
+
+    func.counter = 0
+
+    art = martist.Artist()
+    oid = art.add_callback(func)
+    assert func.counter == 0
+    art.pchanged()  # must call the callback
+    assert func.counter == 1
+    art.set_zorder(10)  # setting a property must also call the callback
+    assert func.counter == 2
+    art.remove_callback(oid)
+    art.pchanged()  # must not call the callback anymore
+    assert func.counter == 2
