'closes' and 'lows' misplaced in candlestick chart

4over7 · story645 · commit 1f7b181a5c8f · 2016-08-16T13:36:13.000-04:00
'closes' and 'lows' are misplaced in candlestick2_ochl function, both in 1.5.1 and 2.* ( i don't know 1.4.* or below). This bug will cause mistakes while ploting, see my answer to this question on stackoverflow: http://stackoverflow.com/a/38684513/4117822 I work 2 hours debuging in 2 a.m. could anybody who saw this vote me up here? T_T
diff --git a/lib/matplotlib/finance.py b/lib/matplotlib/finance.py
@@ -1051,7 +1051,7 @@ def candlestick2_ochl(ax, opens, closes, highs, lows,  width=4,
         (lineCollection, barCollection)
     """
 
-    candlestick2_ohlc(ax, opens, highs, closes, lows, width=width,
+    candlestick2_ohlc(ax, opens, highs, lows, closes, width=width,
                      colorup=colorup, colordown=colordown,
                      alpha=alpha)
 
@@ -1139,8 +1139,8 @@ def candlestick2_ohlc(ax, opens, highs, lows, closes, width=4,
     ax.autoscale_view()
 
     # add these last
-    ax.add_collection(barCollection)
     ax.add_collection(rangeCollection)
+    ax.add_collection(barCollection)
     return rangeCollection, barCollection
 
 
