fixed a hist bug with 1xN inputs

jdh2358 · jdh2358 · commit 214976f758f9 · 2008-05-23T23:17:57.000Z
svn path=/trunk/matplotlib/; revision=5248
diff --git a/examples/pylab/mri_with_eeg.py b/examples/pylab/mri_with_eeg.py
@@ -27,6 +27,7 @@
     im = take(im, nonzero(im)) # ignore the background
     im = im/(2.0**15) # normalize
     hist(im, 100)
+    print im.shape
     xticks([-1, -.5, 0, .5, 1])
     yticks([])
     xlabel('intensity')
@@ -84,6 +85,7 @@
 
     xlabel('time (s)')
 
+if 1:
+    savefig('mri_with_eeg')
 
-#savefig('mri_with_eeg')
 show()
diff --git a/lib/matplotlib/axes.py b/lib/matplotlib/axes.py
@@ -5484,8 +5484,15 @@ def hist(self, x, bins=10, normed=False, cumulative=False,
                 'hist now uses the rwidth to give relative width and not absolute width')
 
         # todo: make hist() work with list of arrays with different lengths
-        x = np.asarray(x)
+        x = np.asarray(x).copy()
+        if len(x.shape)==2 and min(x.shape)==1:
+            x.shape = max(x.shape),
+
+        if len(x.shape)==2 and x.shape[0]<x.shape[1]:
+            warnings.warn('2D hist should be nsamples x nvariables; this looks transposed')
+
         if len(x.shape)==2:
+
             n = []
             for i in xrange(x.shape[1]):
                 # this will automatically overwrite bins,
