Fix casts that apply to whole expression.

QuLogic · QuLogic · commit 2364037f9845 · 2018-02-06T03:58:48.000-05:00
No need to cast the int before dividing, because the divisor is a
double. It is necessary to cast the entire expression though, since the
storage variable is only a float.
diff --git a/src/_png.cpp b/src/_png.cpp
@@ -599,12 +599,12 @@ static PyObject *_read_png(PyObject *filein, bool float_result)
                 if (bit_depth == 16) {
                     png_uint_16 *ptr = &reinterpret_cast<png_uint_16 *>(row)[x * dimensions[2]];
                     for (png_uint_32 p = 0; p < (png_uint_32)dimensions[2]; p++) {
-                        A(y, x, p) = (float)(ptr[p]) / max_value;
+                        A(y, x, p) = (float)(ptr[p] / max_value);
                     }
                 } else {
                     png_byte *ptr = &(row[x * dimensions[2]]);
                     for (png_uint_32 p = 0; p < (png_uint_32)dimensions[2]; p++) {
-                        A(y, x, p) = (float)(ptr[p]) / max_value;
+                        A(y, x, p) = (float)(ptr[p] / max_value);
                     }
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -599,12 +599,12 @@ static PyObject _read_png(PyObject filein, bool float_result)`
`599`	`599`	`if (bit_depth == 16) {`
`600`	`600`	`png_uint_16 ptr = &reinterpret_cast<png_uint_16 >(row)[x * dimensions[2]];`
`601`	`601`	`for (png_uint_32 p = 0; p < (png_uint_32)dimensions[2]; p++) {`
`602`		`- A(y, x, p) = (float)(ptr[p]) / max_value;`
	`602`	`+ A(y, x, p) = (float)(ptr[p] / max_value);`
`603`	`603`	`}`
`604`	`604`	`} else {`
`605`	`605`	`png_byte ptr = &(row[x dimensions[2]]);`
`606`	`606`	`for (png_uint_32 p = 0; p < (png_uint_32)dimensions[2]; p++) {`
`607`		`- A(y, x, p) = (float)(ptr[p]) / max_value;`
	`607`	`+ A(y, x, p) = (float)(ptr[p] / max_value);`
`608`	`608`	`}`
`609`	`609`	`}`
`610`	`610`	`}`